Skip to content

Allow configuring hostname verification for HTTP client - #152

Closed
narekkhachikyan wants to merge 1 commit into
prestodb:masterfrom
narekkhachikyan:narek/configure-hostname-verification
Closed

narekkhachikyan wants to merge 1 commit into
prestodb:masterfrom
narekkhachikyan:narek/configure-hostname-verification

Conversation

@narekkhachikyan

Copy link
Copy Markdown

Cherry-picked from airlift/airlift@a346a03

Adds a verifyHostname config property to HttpClientConfig (defaults to true). When set to false, the HTTPS endpoint identification algorithm is disabled allowing for hostname verification to be bypassed. Useful for communication between the presto worker and coordinator on an EKS cluster.

@narekkhachikyan
narekkhachikyan requested a review from a team as a code owner October 7, 2026 15:48
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@sourcery-ai

sourcery-ai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR introduces a backward-compatible verifyHostname option on HttpClientConfig, defaulting to true, and applies it when constructing Jetty’s SSL context by setting the HTTPS endpoint identification algorithm to null when hostname verification is disabled. Configuration mapping and default-value tests cover both behaviors.

Sequence diagram for configurable HTTPS hostname verification

sequenceDiagram
    participant Config as HttpClientConfig
    participant Client as JettyHttpClient
    participant SSL as SslContextFactory_Client

    Config->>Client: isVerifyHostname()
    Client->>SSL: setEndpointIdentificationAlgorithm(HTTPS)
    alt hostname verification disabled
        Config-->>Client: false
        Client->>SSL: setEndpointIdentificationAlgorithm(null)
    else hostname verification enabled
        Config-->>Client: true
        Client->>SSL: setEndpointIdentificationAlgorithm(HTTPS)
    end
Loading

File-Level Changes

Change Details Files
Add a configurable hostname-verification setting for HTTPS requests, enabled by default.
  • Expose http-client.https.hostname-verification through HttpClientConfig.
  • Use the setting to retain or disable Jetty’s HTTPS endpoint identification algorithm.
  • Extend configuration tests for the default and explicitly disabled cases.
http-client/src/main/java/com/facebook/airlift/http/client/HttpClientConfig.java
http-client/src/main/java/com/facebook/airlift/http/client/jetty/JettyHttpClient.java
http-client/src/test/java/com/facebook/airlift/http/client/TestHttpClientConfig.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@czentgr

czentgr commented Oct 7, 2026

Copy link
Copy Markdown

Superseded by #153, which carries the same cherry-pick with a CLA-covered author. Closing this one.

@czentgr czentgr closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants