Repository navigation
Allow configuring hostname verification for HTTP client - #152
Closed
narekkhachikyan wants to merge 1 commit into
Closed
narekkhachikyan wants to merge 1 commit into
narekkhachikyan wants to merge 1 commit into
Conversation
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR introduces a backward-compatible Sequence diagram for configurable HTTPS hostname verificationsequenceDiagram
participant Config as HttpClientConfig
participant Client as JettyHttpClient
participant SSL as SslContextFactory_Client
Config->>Client: isVerifyHostname()
Client->>SSL: setEndpointIdentificationAlgorithm(HTTPS)
alt hostname verification disabled
Config-->>Client: false
Client->>SSL: setEndpointIdentificationAlgorithm(null)
else hostname verification enabled
Config-->>Client: true
Client->>SSL: setEndpointIdentificationAlgorithm(HTTPS)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
Superseded by #153, which carries the same cherry-pick with a CLA-covered author. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Cherry-picked from airlift/airlift@a346a03
Adds a verifyHostname config property to HttpClientConfig (defaults to true). When set to false, the HTTPS endpoint identification algorithm is disabled allowing for hostname verification to be bypassed. Useful for communication between the presto worker and coordinator on an EKS cluster.