Skip to content

Allow configuring hostname verification for HTTP client - #153

Merged
imjalpreet merged 1 commit into
prestodb:masterfrom
czentgr:cz_hostname_verification
Oct 22, 2026
Merged

imjalpreet merged 1 commit into
prestodb:masterfrom
czentgr:cz_hostname_verification

Conversation

@czentgr

@czentgr czentgr commented Oct 7, 2026

Copy link
Copy Markdown

Cherry-pick of airlift/airlift@a346a03 (original author: Arturo Viveros). Replaces #152, whose commit failed EasyCLA because it kept the upstream author.

Adds http-client.https.hostname-verification to HttpClientConfig (default true). Setting it to false disables the HTTPS endpoint identification algorithm, which lets the Presto worker reach the coordinator over TLS on EKS, where the certificate does not match the pod hostname.

Tested: TestHttpClientConfig passes locally.

Cherry-pick of airlift/airlift@a346a03 (original author: Arturo Viveros).
Adds http-client.https.hostname-verification (default true); false disables
HTTPS endpoint identification.
@czentgr
czentgr requested a review from a team as a code owner October 7, 2026 16:29
@czentgr
czentgr requested a review from imjalpreet October 7, 2026 16:29
@sourcery-ai

sourcery-ai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces the http-client.https.hostname-verification option, enabled by default, and wires it into Jetty’s TLS endpoint identification so deployments can explicitly disable certificate-hostname matching while retaining secure defaults. Configuration tests cover both default behavior and explicit property mapping.

Sequence diagram for configurable HTTPS hostname verification

sequenceDiagram
    participant Config as HttpClientConfig
    participant Client as JettyHttpClient
    participant TLS as SslContextFactory.Client

    Config->>Client: isVerifyHostname()
    alt hostname verification enabled
        Client->>TLS: setEndpointIdentificationAlgorithm(HTTPS)
    else hostname verification disabled
        Client->>TLS: setEndpointIdentificationAlgorithm(null)
    end
Loading

File-Level Changes

Change Details Files
Add a configurable HTTPS hostname-verification setting with secure-by-default behavior.
  • Add the http-client.https.hostname-verification property to HttpClientConfig, defaulting to enabled.
  • Expose the setting through the existing configuration mapping and fluent setter.
http-client/src/main/java/com/facebook/airlift/http/client/HttpClientConfig.java
Apply the hostname-verification setting to Jetty TLS client initialization.
  • Keep Jetty HTTPS endpoint identification set to HTTPS by default.
  • Clear the endpoint identification algorithm when hostname verification is explicitly disabled.
http-client/src/main/java/com/facebook/airlift/http/client/jetty/JettyHttpClient.java
Extend configuration tests for the new default and property mapping.
  • Assert hostname verification is enabled by default.
  • Verify the property maps to a disabled configuration value when set to false.
http-client/src/test/java/com/facebook/airlift/http/client/TestHttpClientConfig.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@czentgr

czentgr commented Oct 22, 2026

Copy link
Copy Markdown
Author

@ZacBlanco Is it possible for you to review this PR? It is a cherry-pick from upstream.

@imjalpreet imjalpreet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @czentgr.

@imjalpreet
imjalpreet merged commit fc00ddf into prestodb:master Oct 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants