Repository navigation
Allow configuring hostname verification for HTTP client - #153
Merged
Merged
Conversation
Cherry-pick of airlift/airlift@a346a03 (original author: Arturo Viveros). Adds http-client.https.hostname-verification (default true); false disables HTTPS endpoint identification.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduces the Sequence diagram for configurable HTTPS hostname verificationsequenceDiagram
participant Config as HttpClientConfig
participant Client as JettyHttpClient
participant TLS as SslContextFactory.Client
Config->>Client: isVerifyHostname()
alt hostname verification enabled
Client->>TLS: setEndpointIdentificationAlgorithm(HTTPS)
else hostname verification disabled
Client->>TLS: setEndpointIdentificationAlgorithm(null)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Author
|
@ZacBlanco Is it possible for you to review this PR? It is a cherry-pick from upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Cherry-pick of airlift/airlift@a346a03 (original author: Arturo Viveros). Replaces #152, whose commit failed EasyCLA because it kept the upstream author.
Adds
http-client.https.hostname-verificationtoHttpClientConfig(defaulttrue). Setting it tofalsedisables the HTTPS endpoint identification algorithm, which lets the Presto worker reach the coordinator over TLS on EKS, where the certificate does not match the pod hostname.Tested:
TestHttpClientConfigpasses locally.