-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Insert into bucketed but unpartitioned Hive table #25139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandamideShakyan
wants to merge
4
commits into
prestodb:master
Choose a base branch
from
anandamideShakyan:insert-bucketed-unpar-hive
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
...-tests/src/test/java/com/facebook/presto/nativetests/TestHivePartitionedInsertNative.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.facebook.presto.nativetests; | ||
|
||
import com.facebook.presto.testing.QueryRunner; | ||
import com.facebook.presto.tests.AbstractTestQueryFramework; | ||
import org.intellij.lang.annotations.Language; | ||
import org.testng.annotations.BeforeClass; | ||
import org.testng.annotations.Test; | ||
|
||
import static io.prestodb.tempto.fulfillment.table.hive.tpch.TpchTableDefinitions.NATION; | ||
import static java.lang.Boolean.parseBoolean; | ||
import static org.testng.Assert.assertEquals; | ||
|
||
public class TestHivePartitionedInsertNative | ||
extends AbstractTestQueryFramework | ||
{ | ||
private String storageFormat; | ||
private boolean sidecarEnabled; | ||
QueryRunner queryRunner; | ||
|
||
@BeforeClass | ||
@Override | ||
public void init() throws Exception | ||
{ | ||
storageFormat = System.getProperty("storageFormat", "PARQUET"); | ||
sidecarEnabled = parseBoolean(System.getProperty("sidecarEnabled", "true")); | ||
super.init(); | ||
} | ||
|
||
@Override | ||
protected QueryRunner createQueryRunner() throws Exception | ||
{ | ||
queryRunner = NativeTestsUtils.createNativeQueryRunner(storageFormat, sidecarEnabled); | ||
return queryRunner; | ||
} | ||
|
||
@Override | ||
protected void createTables() | ||
{ | ||
NativeTestsUtils.createTables(storageFormat); | ||
} | ||
|
||
|
||
@Test | ||
public void testInsertIntoBucketedTables() | ||
{ | ||
String tableName = "hive.tpch.bucketed_nation"; | ||
|
||
// // Clean up previous run | ||
queryRunner.execute("DROP TABLE IF EXISTS " + tableName); | ||
// | ||
// // Create the bucketed table | ||
@Language("SQL") String createTableSql = "CREATE TABLE " + tableName + " (\n" + | ||
" n_nationkey BIGINT,\n" + | ||
" n_name VARCHAR,\n" + | ||
" n_regionkey BIGINT,\n" + | ||
" n_comment VARCHAR\n" + | ||
")\n" + | ||
"WITH (\n" + | ||
" format = 'PARQUET',\n" + | ||
" bucketed_by = ARRAY['n_regionkey'],\n" + | ||
" bucket_count = 2\n" + | ||
")"; | ||
queryRunner.execute(createTableSql); | ||
|
||
// Insert data twice | ||
queryRunner.execute("INSERT INTO "+ tableName + " SELECT * FROM "+NATION.getName()); | ||
queryRunner.execute("INSERT INTO "+ tableName + " SELECT * FROM "+NATION.getName()); | ||
// Validate total row count | ||
assertEquals(queryRunner.execute(queryRunner.getDefaultSession(), "SELECT count(*) FROM " + tableName).toString(), "MaterializedResult{rows=[[50]], types=[bigint], setSessionProperties={}, resetSessionProperties=[]}"); | ||
// Validate filtered row count | ||
assertEquals(queryRunner.execute(queryRunner.getDefaultSession(), "SELECT count(*) FROM " + tableName + " WHERE n_regionkey = 0").toString(), "MaterializedResult{rows=[[10]], types=[bigint], setSessionProperties={}, resetSessionProperties=[]}"); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move these testcases to presto-tests or presto-product-tests? Ideally, we don't want to add new testcases to presto-native-tests, instead we should just extend the existing e2e tests (such as the ones added to presto-product-tests in this PR) to run with with the native query runner.