fix(UI): Use default background color for selected text and misc fixes #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/light color fixes
Contributor
Coverage Report for ./skore-ui
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
glemaitre
reviewed
Jan 8, 2025
glemaitre
reviewed
Jan 8, 2025
glemaitre
previously approved these changes
Jan 8, 2025
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
Apart from the two feedbacks, LGTM for the other changes.
augustebaum
reviewed
Jan 9, 2025
Contributor
augustebaum
left a comment
augustebaum
left a comment
There was a problem hiding this comment.
I noticed the dark mode toggle is not visible in light mode:
2025-01-09T10_19_11_screen_record.mp4
If this is not covered by this PR let me know and I'll open a new issue
Member
|
Interesting. I have it in firefox and in chrome: 
|
Contributor
Author
I cant reproduce it in ff neither in chrome or safari. I'd like to see your browser face to face 😈 |
sylvaincom
approved these changes
Jan 9, 2025
Contributor
sylvaincom
left a comment
sylvaincom
left a comment
There was a problem hiding this comment.
LGTM thanks! We can iterate on this if there are some corners cases
sylvaincom
deleted the
890-view-renaming-text-field-has-a-strong-blue-highlight
branch
waridrox
pushed a commit
to waridrox/skore
that referenced
this pull request
Apr 15, 2025
probabl-ai#1059) Removed pure blue background on editable text (view selector) And various color fixes on dark/light switch. Fixes probabl-ai#890 & probabl-ai#1011.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed pure blue background on editable text (view selector)
And various color fixes on dark/light switch.
Fixes #890 & #1011.