Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions skore-ui/src/assets/styles/_variables.css
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ body[data-vscode-theme-kind="vscode-dark"],

/* shadow */
--color-shadow: rgb(0 0 0/58%);

/* images */
--image-not-found: url("../images/not-found-dark.png");
--image-editor-placeholder: url("../images/editor-placeholder-dark.svg");
--image-activity-feed-placeholder: url("../images/activity-feed-placeholder-dark.svg");
}

body[data-jp-theme-light="true"],
Expand Down Expand Up @@ -108,4 +113,9 @@ body[data-vscode-theme-kind="vscode-light"],

/* shadow */
--color-shadow: rgb(0 0 0/19%);

/* images */
--image-not-found: url("../images/not-found-light.png");
--image-editor-placeholder: url("../images/editor-placeholder-light.svg");
--image-activity-feed-placeholder: url("../images/activity-feed-placeholder-light.svg");
}
8 changes: 8 additions & 0 deletions skore-ui/src/assets/styles/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,11 @@
background-color: var(--color-background-branding);
}
}

.simplebar-inverted {
.simplebar-scrollbar {
&::before {
background-color: var(--color-text-tertiary);
}
}
}
1 change: 1 addition & 0 deletions skore-ui/src/components/DropdownButtonItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const props = withDefaults(defineProps<DropdownItemProps>(), { iconPosition: "le
border: 0;
border-bottom: 1px solid var(--color-stroke-background-primary);
background-color: var(--color-background-primary);
color: var(--color-text-primary);
cursor: pointer;
text-align: left;
white-space: nowrap;
Expand Down
5 changes: 2 additions & 3 deletions skore-ui/src/components/EditableListItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,8 @@ onMounted(() => {
transition: font-weight var(--animation-duration) var(--animation-easing);

&[contenteditable="true"] {
background-color: var(--color-background-branding);
caret-color: var(--color-text-button-primary);
color: var(--color-text-button-primary);
caret-color: var(--color-text-branding);
color: var(--color-text-primary);
cursor: text;
}
}
Expand Down
1 change: 1 addition & 0 deletions skore-ui/src/components/ProjectViewCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ onBeforeUnmount(() => {
& .titles {
position: relative;
padding-left: calc(var(--spacing-8) + 4px);
color: var(--color-text-primary);

& .title {
font-size: var(--font-size-sm);
Expand Down
4 changes: 3 additions & 1 deletion skore-ui/src/components/TreeAccordionItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ onMounted(() => {

& .text {
border-radius: var(--radius-xs);
color: var(--color-text-primary);
}

&.has-children {
Expand All @@ -191,12 +192,13 @@ onMounted(() => {
border: none;
margin: 0;
background-color: transparent;
color: var(--color-text-secondary);
cursor: pointer;
font-size: var(--font-size-md);
transition: color var(--animation-duration) var(--animation-easing);

&:hover {
color: var(--color-primary);
color: var(--color-text-primary);
}
}
}
Expand Down
13 changes: 1 addition & 12 deletions skore-ui/src/views/activity/ActivityFeedView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ onBeforeUnmount(() => {

& .inner {
padding-top: 189px;
background-image: var(--image-activity-feed-placeholder);
background-position: center;
background-repeat: no-repeat;
background-size: 189px 180px;
Expand All @@ -140,16 +141,4 @@ onBeforeUnmount(() => {
}
}
}

@media (prefers-color-scheme: light) {
.activity-feed .placeholder .inner {
background-image: url("../../assets/images/activity-feed-placeholder-light.svg");
}
}

@media (prefers-color-scheme: dark) {
.activity-feed .placeholder .inner {
background-image: url("../../assets/images/activity-feed-placeholder-dark.svg");
}
}
</style>
17 changes: 2 additions & 15 deletions skore-ui/src/views/project/ProjectView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -122,20 +122,6 @@ onBeforeUnmount(() => {
</template>

<style scoped>
@media (prefers-color-scheme: dark) {
main {
--not-found-image: url("../../assets/images/not-found-dark.png");
--editor-placeholder-image: url("../../assets/images/editor-placeholder-dark.svg");
}
}

@media (prefers-color-scheme: light) {
main {
--not-found-image: url("../../assets/images/not-found-light.png");
--editor-placeholder-image: url("../../assets/images/editor-placeholder-light.svg");
}
}

main {
display: flex;
overflow: hidden;
Expand Down Expand Up @@ -204,11 +190,12 @@ main {
flex-direction: column;
justify-content: center;
background-color: var(--color-background-primary);
color: var(--color-text-secondary);

& .wrapper {
padding-top: 225px;
margin: var(--spacing-24);
background-image: var(--editor-placeholder-image);
background-image: var(--image-editor-placeholder);
background-position: 50% 0;
background-repeat: no-repeat;
background-size: 265px 192px;
Expand Down
2 changes: 1 addition & 1 deletion skore-ui/src/views/project/ProjectViewNavigator.vue
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ onBeforeUnmount(() => {
<span>Add a new view</span>
<i class="icon-plus-circle" />
</div>
<Simplebar class="view-list" v-if="views.length > 0">
<Simplebar class="view-list simplebar-inverted" v-if="views.length > 0">
<EditableList
v-model:items="views"
:actions="[
Expand Down
Loading