Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 29, 2025

  • PT003 pytest-extraneous-scope-function
  • PT014 pytest-duplicate-parametrize-test-cases

Duplicate of test case in `pytest.mark.parametrize`
`scope='function'` is implied in `@pytest.fixture()`
@thomass-dev thomass-dev changed the title chore(all): Enforce assorted ruff/flake8-pytest-style rules (PT) chore(all): Enforce PT003 and PT014 rules Oct 29, 2025
Copy link
Collaborator

@thomass-dev thomass-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

PT014 is really a good rule, compare to PT003 which is a bit overkill... I don't think we need more rules like this latest one.

@thomass-dev thomass-dev merged commit d1f68da into probabl-ai:main Oct 29, 2025
64 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PT014 branch October 29, 2025 09:47
@github-actions
Copy link
Contributor

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py39294%90, 109
   metrics_accessor.py178398%173, 253, 1215
   report.py1070100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py90100% 
   data_accessor.py45393%134, 137, 140
   feature_importance_accessor.py240100% 
   metrics_accessor.py182199%244
   report.py135199%487
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py66198%82
   feature_importance_accessor.py141298%223–224
   metrics_accessor.py356897%200, 202, 209, 300, 369, 373, 388, 423
   report.py167298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py102793%61–62, 200, 224–226, 230
   utils.py770100% 
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py185199%706
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%92, 100, 122, 230
   feature_importance_display.py672168%88, 121–122, 124, 142–146, 148–155, 158–160, 162
   metrics_summary_display.py80100% 
   precision_recall_curve.py281598%455, 555, 559, 619, 751
   prediction_error.py227597%179, 186, 422, 505, 705
   roc_curve.py294897%387, 510, 515, 616, 621, 625, 694, 834
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py270100% 
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py75198%120
   widget.py1890100% 
TOTAL402911297% 

Tests Skipped Failures Errors Time
1075 5 💤 0 ❌ 0 🔥 4m 22s ⏱️

@github-actions
Copy link
Contributor

Coverage

Coverage Report for skore-hub-project/
FileStmtsMissCoverMissing
skore-hub-project/src/skore_hub_project
   __init__.py22195%39
   protocol.py310100% 
skore-hub-project/src/skore_hub_project/artifact
   __init__.py00100% 
   artifact.py230100% 
   serializer.py260100% 
   upload.py36488%175, 177–178, 180
skore-hub-project/src/skore_hub_project/artifact/media
   __init__.py50100% 
   data.py220100% 
   feature_importance.py44197%50
   media.py100100% 
   model.py90100% 
   performance.py440100% 
skore-hub-project/src/skore_hub_project/artifact/pickle
   __init__.py20100% 
   pickle.py240100% 
skore-hub-project/src/skore_hub_project/authentication
   __init__.py00100% 
   login.py660100% 
   logout.py40100% 
   token.py240100% 
   uri.py180100% 
skore-hub-project/src/skore_hub_project/client
   __init__.py00100% 
   client.py600100% 
skore-hub-project/src/skore_hub_project/metric
   __init__.py100100% 
   accuracy.py350100% 
   brier_score.py350100% 
   log_loss.py350100% 
   metric.py49197%25
   precision.py610100% 
   r2.py350100% 
   recall.py630100% 
   rmse.py350100% 
   roc_auc.py350100% 
   timing.py90495%52–53, 115–116
skore-hub-project/src/skore_hub_project/project
   __init__.py00100% 
   project.py102397%204, 308, 338
skore-hub-project/src/skore_hub_project/report
   __init__.py30100% 
   cross_validation_report.py64198%204
   estimator_report.py120100% 
   report.py520100% 
TOTAL11861598% 

Tests Skipped Failures Errors Time
139 0 💤 0 ❌ 0 🔥 1m 17s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants