Skip to content

chore(all): Enforce PT003 and PT014 rules #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

chore(all): Enforce PT003 and PT014 rules #2097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9538983
chore(skore): Apply ruff/flake8-pytest-style rule PT014
DimitriPapadopoulos Oct 29, 2025
97de768
chore(skore): Apply ruff/flake8-pytest-style rule PT003
DimitriPapadopoulos Oct 29, 2025
48ad6b4
chore(all): Enforce ruff/flake8-pytest-style rules
DimitriPapadopoulos Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skore-hub-project/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exclude_also = [
]

[tool.ruff.lint]
select = ["E", "F", "UP", "B", "C4", "SIM", "T", "I", "D", "RUF010", "RUF015"]
select = ["E", "F", "UP", "B", "C4", "SIM", "T", "PT003", "PT014", "I", "D", "RUF010", "RUF015"]

[tool.ruff.lint.pydocstyle]
convention = "numpy"
Expand Down
2 changes: 1 addition & 1 deletion skore-local-project/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ exclude_also = [
]

[tool.ruff.lint]
select = ["E", "F", "UP", "B", "C4", "SIM", "T", "I", "D", "RUF010", "RUF015"]
select = ["E", "F", "UP", "B", "C4", "SIM", "T", "PT003", "PT014", "I", "D", "RUF010", "RUF015"]

[tool.ruff.lint.pydocstyle]
convention = "numpy"
Expand Down
2 changes: 2 additions & 0 deletions skore/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ select = [
"SIM",
# flake8-print
"T",
# flake8-pytest-style
"PT003", "PT014",
# isort
"I",
# pydocstyle
Expand Down
2 changes: 1 addition & 1 deletion skore/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def now(*args, **kwargs):
return MockDatetime


@pytest.fixture(scope="function")
@pytest.fixture
def pyplot():
"""Setup and teardown fixture for matplotlib.

Expand Down
5 changes: 0 additions & 5 deletions skore/tests/unit/displays/metrics_summary/test_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,6 @@ def test_scoring_kwargs(
@pytest.mark.parametrize(
"fixture_name, scoring_names, expected_columns",
[
(
"linear_regression_with_test",
["R2", "RMSE", "FIT_TIME", "PREDICT_TIME"],
["R2", "RMSE", "FIT_TIME", "PREDICT_TIME"],
),
(
"linear_regression_with_test",
["R2", "RMSE", "FIT_TIME", "PREDICT_TIME"],
Expand Down
1 change: 0 additions & 1 deletion skore/tests/unit/reports/cross_validation/feature_importance/test_coefficients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def test_cross_validation_report_coefficient_frame(
sklearn.compose.TransformedTargetRegressor(),
id="TransformedTargetRegressor",
),
pytest.param(sklearn.linear_model.ElasticNet(), id="ElasticNet"),
pytest.param(sklearn.linear_model.ARDRegression(), id="ARDRegression"),
pytest.param(sklearn.linear_model.BayesianRidge(), id="BayesianRidge"),
pytest.param(sklearn.linear_model.ElasticNet(), id="ElasticNet"),
Expand Down
1 change: 0 additions & 1 deletion skore/tests/unit/reports/estimator/feature_importance/test_coefficients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ def test_coefficients_pandas_dataframe(estimator):
sklearn.compose.TransformedTargetRegressor(),
id="TransformedTargetRegressor",
),
pytest.param(sklearn.linear_model.ElasticNet(), id="ElasticNet"),
pytest.param(sklearn.linear_model.ARDRegression(), id="ARDRegression"),
pytest.param(sklearn.linear_model.BayesianRidge(), id="BayesianRidge"),
pytest.param(sklearn.linear_model.ElasticNet(), id="ElasticNet"),
Expand Down
5 changes: 0 additions & 5 deletions skore/tests/unit/reports/estimator/feature_importance/test_mean_decrease_impurity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@
@pytest.mark.parametrize(
"data, estimator, expected_shape",
[
(
make_classification(n_features=5, random_state=42),
RandomForestClassifier(n_estimators=2, random_state=0),
(5, 1),
),
(
make_classification(n_features=5, random_state=42),
RandomForestClassifier(n_estimators=2, random_state=0),
Expand Down