-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Soil Measurement] Adds server implementation for soil measurement cluster #38606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 25 commits into
project-chip:master
from
ReneJosefsen:rjosefsen/soil-measurement-server-impl
May 27, 2025
Merged
[Soil Measurement] Adds server implementation for soil measurement cluster #38606
mergify
merged 25 commits into
project-chip:master
from
ReneJosefsen:rjosefsen/soil-measurement-server-impl
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1f47ae
to
6082828
Compare
PR #38606: Size comparison from 7460361 to 6082828 Increases above 0.2%:
Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
6082828
to
3509dce
Compare
PR #38606: Size comparison from f372de5 to 3509dce Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #38606: Size comparison from a12250a to d529ab1 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
d529ab1
to
e13b391
Compare
PR #38606: Size comparison from a12250a to e13b391 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
e60c8f6
to
ae8e49e
Compare
PR #38606: Size comparison from 8167c5f to ae8e49e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
May 12, 2025
examples/all-clusters-app/all-clusters-common/src/soil-measurement-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/include/soil-measurement-stub.h
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/src/soil-measurement-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/src/soil-measurement-stub.cpp
Show resolved
Hide resolved
src/app/clusters/soil-measurement-server/app_config_dependent_sources.cmake
Show resolved
Hide resolved
src/app/clusters/soil-measurement-server/soil-measurement-server.cpp
Outdated
Show resolved
Hide resolved
PR #38606: Size comparison from 8167c5f to 4c75865 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
fessehaeve
reviewed
May 13, 2025
src/app/clusters/soil-measurement-server/soil-measurement-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/soil-measurement-server/soil-measurement-server.cpp
Outdated
Show resolved
Hide resolved
fessehaeve
reviewed
May 21, 2025
src/app/clusters/soil-measurement-server/soil-measurement-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/soil-measurement-server/soil-measurement-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
May 21, 2025
src/app/clusters/soil-measurement-server/soil-measurement-server.cpp
Outdated
Show resolved
Hide resolved
fessehaeve
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
examples
github
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a server implementation for soil measurement as well as adds the soil sensor device type to matter-devices.xml
Testing
Able to build, commission and read out soil measurement attributes using chip-tool on all-clusters app
NOTE: This PR also includes the changes from #38590, so once the XML PR lands I will rebase this PR.