Stop running the MTRDevice dealloc test when pool width is not 1. #38854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmelveilleux
approved these changes
May 9, 2025
|
PR #38854: Size comparison from a46f52c to e3fcc36 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jtung-apple
approved these changes
May 10, 2025
kiel-apple
approved these changes
May 12, 2025
This fails intermittently in testSubscriptionPoolManyDevices, but more importantly: this dealloc test only makes sense in the width-1 case, because if the pool width is not 1 then the test is not testing anything (because nothing gets blocked on the one badly behaving thing if it does behave badly).
bzbarsky-apple
force-pushed
the
skip-dealloc-test-many-devices
branch
from
e3fcc36 to
79348a8
Compare
|
PR #38854: Size comparison from ebe16b7 to 79348a8 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 15, 2025
This reverts commit 47b3a6a. The subscription pool tests were fixed in project-chip#38854. testMTRDeviceDealloc was fixed in project-chip#38809. Both happened before the PR to disable them got through review and landed.
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
…oject-chip#38854) This fails intermittently in testSubscriptionPoolManyDevices, but more importantly: this dealloc test only makes sense in the width-1 case, because if the pool width is not 1 then the test is not testing anything (because nothing gets blocked on the one badly behaving thing if it does behave badly).
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
This reverts commit 47b3a6a. The subscription pool tests were fixed in project-chip#38854. testMTRDeviceDealloc was fixed in project-chip#38809. Both happened before the PR to disable them got through review and landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails intermittently in testSubscriptionPoolManyDevices, but more importantly: this dealloc test only makes sense in the width-1 case, because if the pool width is not 1 then the test is not testing anything (because nothing gets blocked on the one badly behaving thing if it does behave badly).
Testing
Unit test changes only.