Skip to content

Darwin: Avoid making the compiler sad #39139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Darwin: Avoid making the compiler sad #39139

wants to merge 1 commit into from
+1 −2

Conversation

ksperling-apple
Copy link
Contributor

@ksperling-apple ksperling-apple commented May 23, 2025 •
edited by bzbarsky-apple
Loading

Avoid making the compiler sad

Fixes #39135

Testing

Existing CI tests.

@ksperling-apple ksperling-apple requested a review from a team as a code owner May 23, 2025 00:29
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

PR #39139: Size comparison from 8a97eb1 to d811654

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8a97eb1 d811654 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102242 1102242 0 0.0
RAM 179114 179114 0 0.0
bl702 lighting-app bl702+eth FLASH 655348 655348 0 0.0
RAM 135073 135073 0 0.0
bl702+wifi FLASH 832858 832858 0 0.0
RAM 124637 124637 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065398 1065398 0 0.0
RAM 117461 117461 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894952 894952 0 0.0
RAM 105772 105772 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978678 978678 0 0.0
RAM 109956 109956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820588 820588 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 832176 832176 0 0.0
RAM 125440 125440 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 777680 777680 0 0.0
RAM 113844 113844 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 761996 761996 0 0.0
RAM 114052 114052 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548254 548254 0 0.0
RAM 205256 205256 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581694 581694 0 0.0
RAM 205448 205448 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662253 662253 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682105 682105 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682105 682105 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639045 639045 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623645 623645 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643281 643281 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643281 643281 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 644573 644573 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 664281 664281 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 664281 664281 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619241 619241 0 0.0
RAM 70896 70896 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639093 639093 0 0.0
RAM 73528 73528 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639093 639093 0 0.0
RAM 73528 73528 0 0.0
efr32 lock-app BRD4187C FLASH 946772 946772 0 0.0
RAM 132092 132092 0 0.0
BRD4338a FLASH 775728 775728 0 0.0
RAM 173320 173320 0 0.0
window-app BRD4187C FLASH 1039456 1039448 -8 -0.0
RAM 128228 128228 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1809024 1809024 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 122188 122188 0 0.0
FLASH 1775018 1775018 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2776548 2776548 0 0.0
RAM 116312 116312 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6366180 6366180 0 0.0
RAM 535864 535864 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5455986 5455986 0 0.0
RAM 227224 227224 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4790918 4790918 0 0.0
RAM 206880 206880 0 0.0
camera-app debug unknown 8864 8864 0 0.0
FLASH 6899835 6899835 0 0.0
RAM 228152 228152 0 0.0
camera-controller debug unknown 9104 9104 0 0.0
FLASH 14226859 14226859 0 0.0
RAM 656456 656456 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14710887 14710887 0 0.0
RAM 661560 661560 0 0.0
chip-tool-ipv6only arm64 unknown 41016 41016 0 0.0
FLASH 12671208 12671208 0 0.0
RAM 707920 707920 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12791021 12791021 0 0.0
RAM 660928 660928 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4576832 4576832 0 0.0
RAM 192624 192624 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5716805 5716805 0 0.0
RAM 489104 489104 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5638753 5638753 0 0.0
RAM 209048 209048 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4824702 4824702 0 0.0
RAM 196360 196360 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4428790 4428790 0 0.0
RAM 185248 185248 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4556202 4556202 0 0.0
RAM 189184 189184 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3080876 3080876 0 0.0
RAM 150216 150216 0 0.0
thermostat-no-ble arm64 unknown 9744 9744 0 0.0
FLASH 4227888 4227888 0 0.0
RAM 232776 232776 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6082933 6082933 0 0.0
RAM 613336 613336 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12817485 12817485 0 0.0
RAM 771744 771744 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 921652 921652 0 0.0
RAM 167396 167396 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 912904 912904 0 0.0
RAM 145640 145640 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858944 858944 0 0.0
RAM 141159 141159 0 0.0
nxp contact k32w0+release FLASH 592256 592256 0 0.0
RAM 72920 72920 0 0.0
mcxw71+release FLASH 625056 625056 0 0.0
RAM 63260 63260 0 0.0
light k32w0+release FLASH 618316 618316 0 0.0
RAM 72216 72216 0 0.0
k32w1+release FLASH 709568 709568 0 0.0
RAM 72116 72116 0 0.0
lock mcxw71+release FLASH 776192 776192 0 0.0
RAM 67676 67676 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1670612 1670612 0 0.0
RAM 212392 212392 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1575148 1575148 0 0.0
RAM 208576 208576 0 0.0
light cy8ckit_062s2_43012 FLASH 1448108 1448108 0 0.0
RAM 197304 197304 0 0.0
lock cy8ckit_062s2_43012 FLASH 1480324 1480324 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667228 667228 0 0.0
RAM 105244 105244 0 0.0
lock-app qpg6105+debug FLASH 627248 627248 0 0.0
RAM 99872 99872 0 0.0
stm32 light STM32WB5MM-DK FLASH 464964 464964 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 677220 677220 0 0.0
693976 693976 0 0.0
RAM 90944 90944 0 0.0
102084 102084 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 773404 773404 0 0.0
RAM 50236 50236 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770498 770498 0 0.0
RAM 40528 40528 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 758954 758954 0 0.0
780510 780510 0 0.0
RAM 97656 97656 0 0.0
109408 109408 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 686946 686946 0 0.0
702844 702844 0 0.0
RAM 51764 51764 0 0.0
62796 62796 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 715396 715396 0 0.0
740798 740798 0 0.0
RAM 73576 73576 0 0.0
85968 85968 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 712736 712736 0 0.0
RAM 37212 37212 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 607290 607290 0 0.0
607356 607356 0 0.0
RAM 106904 106904 0 0.0
120180 120180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 794004 794008 4 0.0
815820 815824 4 0.0
RAM 96504 96504 0 0.0
107676 107676 0 0.0
tizen all-clusters-app arm unknown 5280 5280 0 0.0
FLASH 1812124 1812124 0 0.0
RAM 95964 95964 0 0.0
chip-tool-ubsan arm unknown 20796 20796 0 0.0
FLASH 21010590 21010590 0 0.0
RAM 9153956 9153956 0 0.0

anush-apple
anush-apple reviewed May 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple anush-apple left review comments

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

Assignees
No one assigned
Labels
darwin fast track platform
Projects
[Platform] Darwin
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Darwin] VerifyOrDie does not compile in ObjC code in src/platform/Darwin
4 participants
@ksperling-apple @andy31415 @anush-apple @bzbarsky-apple