Skip to content

Darwin: Avoid making the compiler sad #39139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Darwin: Avoid making the compiler sad #39139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32fe306
Darwin: Avoid making the compiler sad
ksperling-apple May 23, 2025
46562bc
Merge branch 'master' into darwin-151888447
bzbarsky-apple May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/platform/Darwin/Logging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ __attribute__((const)) void * LoggerForModule(LogModule moduleId);
do \
{ \
_Pragma("clang diagnostic push"); \
_Pragma("clang diagnostic ignored \"-Wshadow\""); \
using os_log_t = ::os_log_t __unsafe_unretained; \
_Pragma("clang diagnostic ignored \"-Wshadow\"") /* issue #39135 */ using os_log_t = ::os_log_t __unsafe_unretained; \
os_log_with_type((__bridge os_log_t) log, type, fmt, ##__VA_ARGS__); \
_Pragma("clang diagnostic pop"); \
} while (0)
Expand Down
Loading