Disable All Groupcast Functionality by Default#72047
Merged
mergify[bot] merged 13 commits intoMay 14, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables Groupcast by default across various example applications and build configurations, transitioning it to an opt-in feature via a new --groupcast command-line argument in the POSIX all-devices-app. Corresponding updates were made to the CI test scripts to include this flag. A review comment identifies a regression in GroupsCluster.cpp, where the removal of conditional logic for the cluster revision causes the device to incorrectly report support for Groupcast-related features even when the functionality is disabled.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72047 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 1619 1619
Lines 110379 110380 +1
Branches 13486 13486
=======================================
+ Hits 60593 60594 +1
Misses 49786 49786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #72047: Size comparison from 69d8d7c to 07eadbb Full report (33 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
|
PR #72047: Size comparison from 06fce34 to 19e7fab Full report (30 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
tcarmelveilleux
approved these changes
May 14, 2026
|
PR #72047: Size comparison from 06fce34 to eed46aa Full report (16 builds for cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
jmartinez-silabs
approved these changes
May 14, 2026
|
PR #72047: Size comparison from 06fce34 to 07ccd7b Full report (21 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
for more information, see https://pre-commit.ci
|
PR #72047: Size comparison from 06fce34 to dbce0d0 Full report (33 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
zaid-google
added
the
request-backport-sve
mergify Bot
pushed a commit
that referenced
this pull request
May 15, 2026
* Add README.md to all-devices-app (#71734) * Add README.md to all-devices-app * Restyled by prettier-markdown * Fix spelling in README.md * Update firewall instructions in README.md for security * Update examples/all-devices-app/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Restyled by prettier-markdown * Add README to toctree in all_devices.md * Clarify generic nature of firewall troubleshooting in README.md * Move generic firewall instructions to dedicated file and link from README * Remove firewall instructions and dedicated file from README * Update examples/all-devices-app/README.md Co-authored-by: Andrei Litvin <andy314@gmail.com> * Simplify Chime examples and remove bash script from README * Manually apply restyling for long line in README.md * restyle * Correct platform directory list in README.md * Restyled by prettier-markdown * Use in-project link for chip-tool documentation in README * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> * [all-devices-app] Support parent/child endpoint relationships via command line (#71756) * Support parent/child endpoint relationships via command line in all-devices-app * Restyled by whitespace * Restyled by clang-format * Document parent/child endpoint relationship feature in README.md * Restyled by prettier-markdown * Fix logging format for endpoint IDs in main.cpp * Simplify logging format in main.cpp to save flash * Apply restyling to main.cpp * Refactor device type parsing in all-devices-app - Extracted parsing logic to a reusable DeviceTypeParser component in all-devices-common. - Updated CLI syntax to use comma-separated options (e.g., type:endpoint,parent=parentId). - Removed redundant --endpoint option. - Removed Singleton pattern from DeviceTypeParser and used dependency injection/facade pattern. - Moved default device policy to application code in main.cpp. - Added unit tests for the parser. - Updated help text and README.md with new syntax. * Restyle files after refactor * Revert spurious flags.gni change * Move default device fallback to AppOptions * Fix duplicate test target in device-type-parser/BUILD.gn * Restyle fixes for BUILD.gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [all-devices-app] Add cmd line options "--KVS, --discriminator, --vendor-id, --product-id --interface-id" and remove dependency on global LinuxDeviceOptions (#71735) * Refactor all-devices-app to remove reliance on global options and add KVS support * Fix compilation errors in main.cpp after AppOptions refactor * Add support for --vendor-id and --product-id options in all-devices-app * Address review comments: make GetConfig() const and restore default device fallback * Rename deviceConfigs to deviceTypeEntries for consistency * Update DeviceTypeParser: rename member variable and fix doc comment * Add validation for discriminator option * Move AppDeviceInstanceInfoProvider to a separate header file * Separate AppDeviceInstanceInfoProvider into .h and .cpp files * Apply restyling and style fixes * Move provider files to all-devices-common (rename only) * Implement full DeviceInfoProviderImpl and update build files * Apply restyling fixes * Rename DeviceInstanceInfoProviderImpl to OverrideDeviceInstanceInfoProvider and add safe fallbacks * Support setting port dynamically via --port option * Support --interface-id option in all-devices-app * Split providers into separate source sets and fix includes * Use short include paths for files in all-devices-common * Move providers to a separate sub-directory in all-devices-common * Remove singleton from DeviceInfoProviderImpl and move instance to local static in Initialize * Rename DeviceInfoProviderImpl to TestDeviceInfoProviderImpl * Implement Friend Pattern for iterators in TestDeviceInfoProviderImpl * Use VerifyOrReturnError pattern in OverrideDeviceInstanceInfoProvider.cpp * Fully switch to std::optional in AppOptions and OverrideDeviceInstanceInfoProvider * Use value_or for port in main.cpp and always log the port used * Rename TestDeviceInfoProviderImpl back to AllDevicesExampleDeviceInfoProviderImpl * Rename OverrideDeviceInstanceInfoProvider to AllDevicesExampleDeviceInstanceInfoProviderImpl and apply restyling * Use value_or for discriminator in main.cpp * Disable All Groupcast Functionality by Default (#72047) * Initial updates to zap, gni, all devices args, python tests * Remove args.gni file that wasnt needed * Fix compile issues * Update python tests all devices app args * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Zap regen * Remove unimplemented app arg * max groups per fabric revert to legacy unless for constructor * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Cast to uint16_t and make hex value lowercase * add todo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix build issues w/ GROUPS CLUSTER and temp sensor gn * Restyled by clang-format * remove unused ble arg (this works wasnt cherry-picked) * zap regen --------- Co-authored-by: Sergio Soares <sergiosoares@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
May 22, 2026
* Initial updates to zap, gni, all devices args, python tests * Remove args.gni file that wasnt needed * Fix compile issues * Update python tests all devices app args * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Zap regen * Remove unimplemented app arg * max groups per fabric revert to legacy unless for constructor * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Cast to uint16_t and make hex value lowercase * add todo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Groupcast is provisional and should for now, be disabled by default on all apps. Legacy groups functionality should remain intact. This PR makes the following changes:
Disables groupcast in zap files where it was previously enabled
Zap regen
Make
chip_config_enable_groupcastfalse by default for all appsAdd a
-groupcastapp argument to all devices app to ensure there's a way to still test groupcast functionality with this app. Groupcast will be disabled by default but this will enable it.Make
GroupDataProviderImpl()default constructor useCHIP_CONFIG_MAX_GROUPS_PER_FABRICinstead ofkMaxMembershipPerFabricformaxGroupsPerFabric. This reverts the value back to what it was for legacy groupsGetMaxGroupsPerFabric(), to return eithergetMaxMembershipCount() / 2if groupcast is enabled, ormMaxGroupsPerFabricotherwise. This is needed because groupcast can still be enabled at runtime for all devices app (like it is now doing in some tests for CI).getMaxMembershipCount()returnskMaxMembershipCount, so this retains the functionality that was introduced for groupcast in [Groupcast] Align GroupDataProvider limits with membership count #43167Testing