Remove OUTPUT_DIR from tekton

[dlabrecq]

The caddyfile default (/dist) is being overriden by the OUTPUT_DIR param in tekton

Summary by Sourcery

Upgrade Node.js and npm versions across the project and CI, adjust build scripts accordingly, and eliminate the OUTPUT_DIR Tekton build argument in favor of APP_BUILD_DIR to preserve the default output directory.

Enhancements:

• Bump Node.js requirement to 22.20.0 and npm to 11.6.2 in package.json across all workspaces

Build:

• Update build_deploy.sh and pr_check.sh scripts to use Node 22

CI:

• Update GitHub Actions CI workflow to use NodeJS version 22

Deployment:

• Remove OUTPUT_DIR build-arg from Tekton pipelines and replace with APP_BUILD_DIR for koku-ui-hccm and koku-ui-ros

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the OUTPUT_DIR build-arg from Tekton pipelines (replacing it with APP_BUILD_DIR) to preserve the default caddyfile directory and synchronizes Node.js/NPM version requirements across package.json, CI workflows, and build scripts.

File-Level Changes

Change	Details	Files
Remove OUTPUT_DIR and introduce APP_BUILD_DIR in Tekton tasks	Removed OUTPUT_DIR build-arg defaults Added APP_BUILD_DIR build-arg defaults	.tekton/koku-ui-hccm-pull-request.yaml .tekton/koku-ui-hccm-push.yaml .tekton/koku-ui-ros-pull-request.yaml .tekton/koku-ui-ros-push.yaml
Bump Node.js and npm engine versions in package.json	Updated node requirement from >=20.15.0 to >=22.20.0 Updated npm requirement from >=10.8.0 to >=11.6.2	apps/koku-ui-hccm/package.json apps/koku-ui-ros/package.json package.json
Update NodeJS version in GitHub Actions CI workflow	Changed NODEJS_VERSION env var from '20' to '22'	.github/workflows/ci.yml
Bump NODE_BUILD_VERSION in hccm build scripts	Changed NODE_BUILD_VERSION from 20 to 22	apps/koku-ui-hccm/build_deploy.sh apps/koku-ui-hccm/pr_check.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @dlabrecq, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the build process for the koku-ui-hccm and koku-ui-ros applications within the Tekton pipelines. By removing a redundant OUTPUT_DIR parameter, it resolves a conflict where the Tekton configuration was inadvertently overriding the intended default output directory, thereby ensuring consistency with the caddyfile's expected build artifact location.

Highlights

• Tekton Configuration Update: The explicit OUTPUT_DIR parameter has been removed from the build-args default list within the Tekton pipeline configurations for koku-ui-hccm and koku-ui-ros.
• Resolution of Output Directory Override: This change addresses an issue where the OUTPUT_DIR parameter was overriding the default /dist path expected by the caddyfile, ensuring that the correct build output location is now respected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request removes the OUTPUT_DIR build argument from the Tekton pipeline configurations for koku-ui-hccm and koku-ui-ros. This change is intended to fix an issue where the explicit OUTPUT_DIR was overriding the Caddy server's default directory (/dist), causing problems with serving the application. The changes are consistent across the pull request and push pipelines for both applications and appear to be a correct fix for the described problem. The changes look good and I have no further suggestions.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.82%. Comparing base (a7ffd0c) to head (13d0fbe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4601   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files         480      480           
  Lines        9075     9075           
  Branches     2198     2198           
=======================================
  Hits         8061     8061           
+ Misses        954      953    -1     
- Partials       60       61    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Verify that your Dockerfiles or shared builder scripts have been updated to consume the new APP_BUILD_DIR build-arg and that there are no leftover references to OUTPUT_DIR.
• Ensure that the Node/NPM versions defined in package.json engines are actually installed in both GitHub Actions and Tekton (so builds remain consistent across environments).

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Verify that your Dockerfiles or shared builder scripts have been updated to consume the new APP_BUILD_DIR build-arg and that there are no leftover references to OUTPUT_DIR.
- Ensure that the Node/NPM versions defined in package.json engines are actually installed in both GitHub Actions and Tekton (so builds remain consistent across environments).

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}