Skip to content

Add ktfmt to spotless to format build files#514

Merged
rnc merged 2 commits into
project-ncl:mainfrom
rnc:BR1
Oct 2, 2025
Merged

Add ktfmt to spotless to format build files#514
rnc merged 2 commits into
project-ncl:mainfrom
rnc:BR1

Conversation

@rnc

@rnc rnc commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.26%. Comparing base (f9c7b20) to head (ffb8e79).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files          42       42           
  Lines        2600     2600           
  Branches      356      356           
=======================================
  Hits         2087     2087           
  Misses        383      383           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread build.gradle.kts
tasks.register("AggregateJacocoReport")
}
tasks.withType<Wrapper>().configureEach { distributionType = Wrapper.DistributionType.ALL }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some reordering so the file makes more sense when reading.

Comment thread build.gradle.kts
}
if (GradleVersion.current() >= GradleVersion.version("${project.extra.get("gradleReleaseVersion")}")) {
apply { from("$rootDir/gradle/spotless.gradle") }
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than doing complicated reflection (as certain parts of ktfmt isn't available on earler versions, just move it to a groovy file.

@rnc rnc merged commit eb51b2a into project-ncl:main Oct 2, 2025
82 of 84 checks passed
@rnc rnc deleted the BR1 branch October 2, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant