-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[prometheus-elasticsearch-exporter] Deployment volumes volumeMounts fix #5493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zeritti
merged 7 commits into
prometheus-community:main
from
bobanj:elasticsearch-deployment-volumes-fix
Apr 2, 2025
Merged
[prometheus-elasticsearch-exporter] Deployment volumes volumeMounts fix #5493
zeritti
merged 7 commits into
prometheus-community:main
from
bobanj:elasticsearch-deployment-volumes-fix
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s presence fix Signed-off-by: Boban Jovanoski <[email protected]>
Signed-off-by: Boban Jovanoski <[email protected]>
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
zeritti
requested changes
Apr 1, 2025
Contributor
zeritti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bobanj, for your PR. I have added further test cases including those for the fields affected in this PR.
charts/prometheus-elasticsearch-exporter/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
…to elasticsearch-deployment-volumes-fix
…anj/helm-charts into elasticsearch-deployment-volumes-fix
… at end of file Signed-off-by: Boban Jovanoski <[email protected]>
zeritti
approved these changes
Apr 2, 2025
Contributor
zeritti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bobanj, LGTM
hedgieinsocks
pushed a commit
to hedgieinsocks/prom-helm-charts
that referenced
this pull request
Apr 27, 2025
…ix (prometheus-community#5493) Signed-off-by: Boban Jovanoski <[email protected]> Signed-off-by: zeritti <[email protected]> Co-authored-by: zeritti <[email protected]> Signed-off-by: Artyom Babiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])