Skip to content

Conversation

@bobanj
Copy link
Contributor

@bobanj bobanj commented Apr 1, 2025

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bobanj, for your PR. I have added further test cases including those for the fields affected in this PR.

bobanj added 2 commits April 2, 2025 11:57
…anj/helm-charts into elasticsearch-deployment-volumes-fix
@bobanj bobanj requested a review from zeritti April 2, 2025 10:01
Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bobanj, LGTM

@zeritti zeritti merged commit db00155 into prometheus-community:main Apr 2, 2025
5 checks passed
hedgieinsocks pushed a commit to hedgieinsocks/prom-helm-charts that referenced this pull request Apr 27, 2025
…ix (prometheus-community#5493)

Signed-off-by: Boban Jovanoski <[email protected]>
Signed-off-by: zeritti <[email protected]>
Co-authored-by: zeritti <[email protected]>
Signed-off-by: Artyom Babiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[prometheus-elasticsearch-exporter] Empty Volumes and VolumeMounts

2 participants