[CHAIN] feat(ui): expand attack paths node legend coverage#11016
Merged
Alan-TheGentleman merged 1 commit intoPROWLER-1273/react-flow-migrationfrom May 8, 2026
Merged
Conversation
This was referenced May 6, 2026
pfe-nazaries
approved these changes
May 7, 2026
| export const GraphLegend = ({ data }: GraphLegendProps) => { | ||
| export const GraphLegend = ({ | ||
| data, | ||
| expandedResources = new Set(), |
Contributor
There was a problem hiding this comment.
When no prop passed, this will create a new Set each render with a different ref, trigger unnecessary renders
651fa45 to
b20ad88
Compare
c309218 to
bc212d5
Compare
Base automatically changed from
PROWLER-1273/attack-path-legend-redesign
to
PROWLER-1273/react-flow-migration
May 8, 2026 12:48
bc212d5 to
bd8880b
Compare
d50782d
into
PROWLER-1273/react-flow-migration
3 checks passed
Alan-TheGentleman
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Part of Chained PRs
PROWLER-1273/react-flow-migrationChain Overview
Context
This closes the icon/legend coverage gap for real Attack Paths node labels. The previous legend was too category-oriented; reviewers need the legend to explain the concrete node types visible in the graph, using the same colors as the nodes themselves.
Description
Changes:
resolveNodeVisual()coverage for AWS labels used by predefined Attack Paths queries, including RDS, Lambda, SageMaker notebooks, load balancers, listeners, network interfaces, IP nodes, groups, principals, and tags.AWS User,AWS Managed Policy,AWS Policy Statement, andPermission Roleinstead of generic categories likeIdentity.Steps to review
pnpm exec vitest run --project unit "app/(prowler)/attack-paths/(workflow)/query-builder/_components/graph/graph-legend.test.tsx" "app/(prowler)/attack-paths/(workflow)/query-builder/_lib/node-visuals.test.ts"fromui/.Checklist
Community Checklist
UI
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.