Skip to content

Conversation

@sandrobonazzola
Copy link
Collaborator

  • Dropped usage of deprecated module codecs
  • Added Python 3.14 to setup.py
  • Update pre-commit and pylint config accordingly

Fixes #439

- Dropped usage of deprecated module codecs
- Added Python 3.14 to setup.py
- Update pre-commit and pylint config accordingly

Fixes psss#439

Signed-off-by: Sandro Bonazzola <[email protected]>
@sandrobonazzola sandrobonazzola requested a review from kwk November 12, 2025 12:27
Copy link
Collaborator

@kwk kwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes tests.

@webknjaz
Copy link

Added Python 3.14 to setup.py

That's just a Trove classifier which is a thing that shows up in interfaces but really does nothing. It's a good idea to set the minimum supported version in python_requires, which would actually influence the dependency resolution. Though, it's not technically in the scope of this PR.

@kwk
Copy link
Collaborator

kwk commented Nov 13, 2025

I've restarted some tests a few times because we were hitting rate limits with github for example. Now everything looks fine.

@kwk kwk merged commit f3ec56b into psss:main Nov 13, 2025
15 checks passed
@kwk kwk mentioned this pull request Nov 13, 2025
@sandrobonazzola sandrobonazzola deleted the issue_439 branch November 13, 2025 09:43
@sandrobonazzola sandrobonazzola self-assigned this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python3.14 breaks pre-commit: AttributeError: module 'ast' has no attribute 'NameConstant'

3 participants