Clear allocation notes on server deletion

[giomxx]

Currently when a user sets notes for an allocation, it's saved to the DB, then never touched again. When the server is deleted, the notes on that allocation are preserved.

This means that the DB can get filled with allocations with note entries, and a NULL server ID, and when the allocation eventually get's reused for another server, the note is displayed for the allocations on the new server.

My PR fixes this by ensuring the notes are removed from the allocations during the server deletion process.

[rmartinoscar]

Hey that would work for server deleted since the change but older allocations will still have their notes we need to use a migration as well, something like this should do the job

database/migrations/2024_07_12_170235_clear_notes_on_unused_allocations.php

<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Support\Facades\DB;

return new class extends Migration
{
    /**
     * Run the migrations.
     */
    public function up(): void
    {
        DB::table('allocations')
            ->where('server_id', null)
            ->whereNot('notes', null)
            ->update(['notes' => null]);
    }

    /**
     * Reverse the migrations.
     */
    public function down(): void
    {
        // Reverse not needed
    }
};

[giomxx]

@rmartinoscar Thanks! I had completely forgot about that. I've added the migration script now. 😅

[DaneEveritt]

@giomxx you have some (all) failing tests.