Fix required properties with default in TF projecting as non-optional in Pulumi

[VenelinMartinov]

This PR fixes the schema generation for TF properties which are marked as Required and have a default.

In TF these become optional, as the default will get applied. This PR makes this also the case in Pulumi. SDKs should no longer require such properties to be specified as inputs.

This change should be fully backwards-compatible, see here for a per-language discussion.

fixes #2204

[codecov]

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@31a6c1e). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
pkg/pf/internal/pfutils/default.go	85.71%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3035   +/-   ##
=======================================
  Coverage        ?   68.59%           
=======================================
  Files           ?      335           
  Lines           ?    43414           
  Branches        ?        0           
=======================================
  Hits            ?    29782           
  Misses          ?    11952           
  Partials        ?     1680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[VenelinMartinov]

This change is part of the following stack:

• Fix PF WriteOnly attributes skip #3043
  • Fix required properties with default in TF projecting as non-optional in Pulumi #3035 ◀
    • Fix nested fully computed properties showing as settable #3044

_{Change managed by git-spice.}

[t0yv0]

LGTM modulo some nits.

[t0yv0]

Given recent findings in pulumi-aws let's flag this so some providers can implement as part of a major version change.

[VenelinMartinov]

@t0yv0 which findings? I've tested this on AWS and I don't think it is affected at all

[t0yv0]

Something like pulumi/pulumi-aws#5483 might indicate that at scale user programs rely on type details because output types can unexpectedly get reused in negative type positions. While arguably we do not support this, breaking a lot of programs is bad form; I think that since this change involves type changes we could minimize this impact for example by rolling it out through major releases for Tier 1 providers.

[VenelinMartinov]

@t0yv0 no types in either GCP or AWS are affected - I think this isn't as widely impacting as initially assumed. Seems redundant to add the additional complexity of flagging the rollout here.

[t0yv0]

Can you add a flag to turn it off if needed? On by default but can be turned off. Thanks.

[pulumi-bot]

This PR has been shipped in release v3.109.0.