Skip to content

Conversation

VenelinMartinov
Copy link
Contributor

Fix nested fully computed properties showing as settable

repros

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented May 1, 2025

Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 48.75000% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@31a6c1e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...testprovider/schema_required_input_with_default.go 0.00% 20 Missing ⚠️
.../internal/testprovider/optionalinputwithdefault.go 0.00% 15 Missing ⚠️
pkg/pf/internal/pfutils/default.go 78.57% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3044   +/-   ##
=======================================
  Coverage        ?   34.93%           
=======================================
  Files           ?      316           
  Lines           ?    42081           
  Branches        ?        0           
=======================================
  Hits            ?    14701           
  Misses          ?    25945           
  Partials        ?     1435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VenelinMartinov VenelinMartinov force-pushed the vvm/fix_required_with_default branch from 461c765 to 2d8f21d Compare May 6, 2025 13:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/fix_nested_fully_computed branch from 5818631 to 3d24dfc Compare May 6, 2025 13:42
Base automatically changed from vvm/fix_required_with_default to main May 6, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants