Update references to info types #3206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 68.79% 68.77% -0.02%
==========================================
Files 336 336
Lines 43995 43995
==========================================
- Hits 30265 30259 -6
- Misses 12026 12030 +4
- Partials 1704 1706 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blampe
commented
Oct 9, 2025
Comment on lines
-257
to
+271
| return | ||
| return n, err | ||
| } | ||
|
|
||
| raw := strings.TrimSuffix(string(p), "\n") | ||
| level, raw := parseLevelFromRawString(raw) | ||
|
|
||
| if level < w.desiredLevel { | ||
| return | ||
| return n, err | ||
| } | ||
|
|
||
| urn, raw := parseUrnFromRawString(raw) | ||
| severity := logLevelToSeverity(level) | ||
|
|
||
| err = w.sink.Log(w.ctx, severity, urn, raw) | ||
| return | ||
| return n, err |
There was a problem hiding this comment.
There are a few other changes like this to fix local lint errors. CI must be using a less strict lint config?
There was a problem hiding this comment.
We've seen this in pulumi/pulumi upgrading to golangci-lint 2.5.0. This is because of a newer version of gofumpt, which requires these return values now.
iwahbe
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1879.
This updates our usage of
infotypes to use the types directly instead oftheir aliases. This is a prerequisite to being able to mark the aliases as
deprecated.
Moving to the
infopackage's shared API types allows consumers to linkagainst a significantly smaller surface area.