put "unvalidated" args in separate argument during argument validation #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j4ys0n as I am reviewing this and thinking through it, would it not make more sense to pass those hidden values in headers? |
|
Alternatively, if the goal is to get extra params without defining them in the schema, could you not just change the schema to use |
|
Apologies for the delay. Yeah, could do |
|
@punkpeye want me to change this or no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tool arguments are validated against the defined schema, instead of removing arguments that aren't in the schema, this will move them to a separate argument called
extraArgsthis is available in the tools' execution handler. This was done to be able to handle sensitive values like api keys or authentication tokens without adding them to the schema that the LLM will use.