-
Notifications
You must be signed in to change notification settings - Fork 5
Add PuppetCore gem source support to module_ci workflow #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58e65f7
to
d15a267
Compare
- Add ruby_version input parameter with default of '2.7' - Add puppetcore_api_type input parameter with default of 'forge-key' - Configure environment variables for Puppet Core authentication - Update ruby-version in workflow to use the input parameter - Add documentation on requirements for enabling PuppetCore Signed-off-by: Gavin Didrichsen <[email protected]>
3d669d0
to
2c51e06
Compare
Verification using a puppetcore repositoryThis provision PR introduces puppetcore and re-uses the new shared
![]()
The main advantage of this change to the Verification using a non-puppetcore repositoryFurther, this ![]() |
Signed-off-by: Gavin Didrichsen <[email protected]>
Signed-off-by: Gavin Didrichsen <[email protected]>
One of the cat-github-actions re-usable workflows has been updated to switch on the puppetcore. For reference see <puppetlabs/cat-github-actions#129>. This means a minor admustment is required on any modules that also need to run against puppetcore. One, `ruby_version` must be passed in and be >= 3.1; and two, the `PUPPET_FORGE_TOKEN` must be a secret on the repository. Signed-off-by: Gavin Didrichsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
This PR enhances the module_ci reusable workflow to support the PuppetCore private gem source. This allows modules using this workflow to access private Puppet gems when needed.
Changes
PUPPET_FORGE_TOKEN
. This "secret" is then in turn used to set theBUNDLE_RUBYGEMS___PUPPETCORE__PUPPET__COM
which enables authenticated access to the puppetcore gemsALSO added a how to document for consumers of this re-usable module, see
docs/how-to/how_to_using_module_ci_workflow_with_puppetcore_gems.md
Impact
module_ci.yml
has been verified with both a puppetcore enabled module https://github.com/puppetlabs/provision and a non-puppetcore one https://github.com/puppetlabs/puppetlabs-apache. See in the comments below for proof of testing.