Skip to content

Add PuppetCore gem source support to module_ci workflow #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/module_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,23 @@ on:
required: false
default: false
type: "boolean"
ruby_version:
description: "Ruby version to use"
required: false
default: '2.7'
type: "string"
puppetcore_api_type:
description: "The type of API to use for Puppet Core."
required: false
default: 'forge-key'
type: "string"

# ENABLE PUPPETCORE. The calling workflow must:
# - Set a valid PUPPET_FORGE_TOKEN secret on its repository.
# - Set ruby_version >= 3.1 to override this workflow's default 2.7; otherwise bundle install will fail.
env:
PUPPET_FORGE_TOKEN: ${{ secrets.PUPPET_FORGE_TOKEN }}
BUNDLE_RUBYGEMS___PUPPETCORE__PUPPET__COM: "${{ inputs.puppetcore_api_type }}:${{ secrets.PUPPET_FORGE_TOKEN }}"

jobs:
setup_matrix:
Expand All @@ -41,7 +57,7 @@ jobs:
- name: "Setup ruby"
uses: "ruby/setup-ruby@v1"
with:
ruby-version: "2.7"
ruby-version: ${{ inputs.ruby_version }}
bundler-cache: true

- name: "Bundle environment"
Expand Down
105 changes: 105 additions & 0 deletions docs/how-to/how_to_using_module_ci_workflow_with_puppetcore_gems.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
# How to use the module_ci workflow with puppetcore gems

## Description

This guide explains how to configure your repository to use the shared `module_ci.yml` workflow with PuppetCore Gems. The workflow is designed to maintain backward compatibility with existing consumers (like puppetlabs-apache and puppetlabs-ntp) while providing the capability to install and use gems from the private PuppetCore gem source.

## Prerequisites

- A GitHub repository that needs to use the `module_ci.yml` workflow
- Access to repository settings to configure secrets
- A valid `PUPPET_FORGE_TOKEN` with access to the private gem source

## Configuration Requirements

### Required Settings

To use PuppetCore Gems with the module_ci workflow, your repository must meet these requirements:

1. **Set up the PUPPET_FORGE_TOKEN secret**:
- Navigate to your repository on GitHub
- Go to Settings > Secrets and variables > Actions
- Add a new repository secret named `PUPPET_FORGE_TOKEN` with your valid token value

2. **Configure Ruby Version**:
- Must specify a Ruby version >= 3.1 (required for PuppetCore Gems)
- The default Ruby version in module_ci.yml is 2.7 and must be overridden

### Optional Settings

- **PuppetCore API Type**:
- By default, set to 'forge-key'
- Can be changed to 'license-key' if required

## Usage

Create or update your workflow file (typically `.github/workflows/ci.yml`) to look something like:

```yaml
name: "ci"

on:
pull_request:
branches:
- "main"
workflow_dispatch:

jobs:
Spec:
uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
with:
run_shellcheck: true
ruby_version: '3.1' # Required for PuppetCore Gems
secrets: "inherit" # Required to pass PUPPET_FORGE_TOKEN
```

## How It Works

When properly configured, the `module_ci.yml` workflow will:

1. Inherit the `PUPPET_FORGE_TOKEN` secret from the consumer repository.
2. Set the following `BUNDLE_RUBYGEMS___PUPPETCORE__PUPPET__COM` environment variable ensuring authentication against the <https://rubygems-puppetcore.puppet.com> gemsource, e.g,:

```shell
BUNDLE_RUBYGEMS___PUPPETCORE__PUPPET__COM: "forge-key:${{ secrets.PUPPET_FORGE_TOKEN }}"
```

3. Install gems from <https://rubygems-puppetcore.puppet.com>.

## Troubleshooting

Common issues and their solutions:

- **Bundle install fails**: Ensure Ruby version is set to at least 3.1
- **Authentication errors**: Verify the PUPPET_FORGE_TOKEN is correctly set and has appropriate permissions

## Appendix

### Sample Implementation

Example configuration in a consuming repository:

```yaml
name: "ci"

on:
pull_request:
branches:
- "main"
workflow_dispatch:

jobs:
Spec:
uses: "puppetlabs/cat-github-actions/.github/workflows/module_ci.yml@main"
with:
run_shellcheck: true
ruby_version: '3.1'
puppetcore_api_type: 'license-key'
secrets: "inherit"
```

### Security Considerations

- Never hardcode the PUPPET_FORGE_TOKEN in your workflow files
- Use the `secrets: "inherit"` pattern to securely pass tokens
- Regularly rotate your tokens following security best practices