Skip to content

Bug/1570 Visual has the wrong color #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MasterEvarior merged 18 commits into from
Aug 19, 2025
Merged

Bug/1570 Visual has the wrong color #1598

MasterEvarior merged 18 commits into from
Aug 19, 2025

Conversation

@lcanobbio
Copy link
Collaborator

@lcanobbio lcanobbio commented Aug 5, 2025

No description provided.

@lcanobbio lcanobbio linked an issue Aug 5, 2025 that may be closed by this pull request
Visual has the wrong color #1570
Closed
@lcanobbio lcanobbio force-pushed the bug/1570-visual-has-the-wrong-color branch from 361298c to 454f8ef Compare August 12, 2025 06:48
@lcanobbio lcanobbio assigned lcanobbio and nevio18324 and unassigned lcanobbio Aug 12, 2025
@lcanobbio lcanobbio requested review from ManuelMoeri and nevio18324 and removed request for ManuelMoeri August 12, 2025 14:31
@nevio18324
Copy link
Collaborator

nevio18324 commented Aug 13, 2025 •
edited
Loading

Das Ticket ist fast fertig scoring e2e tests failen noch
Ein e2e test muss geschrieben werden welcher überprüft das der selbe bug nicht nocheinmal auftritt
Und das naming muss noch besprochen werden ob es wirklich wordingCommitValue, wordingTargetValue heissen?

@peggimann
Copy link
Collaborator

peggimann commented Aug 13, 2025 •
edited
Loading

Das Ticket ist fast fertig scoring e2e tests failen noch Ein e2e test muss geschrieben werden welcher überprüft das der selbe bug nicht nocheinmal auftritt Und das naming muss noch besprochen werden ob es wirklich wordingCommitValue, wordingTargetValue heissen?

Ich denke, dass ist ein Missverständnis, ich würde es commitValue etc. nennen. Nice catch!

@ManuelMoeri ManuelMoeri force-pushed the bug/1570-visual-has-the-wrong-color branch from 04a720f to 92c5146 Compare August 14, 2025 11:54
@lcanobbio lcanobbio force-pushed the bug/1570-visual-has-the-wrong-color branch from 13434d5 to 542d7c7 Compare August 15, 2025 09:58
@nevio18324 nevio18324 assigned lcanobbio and unassigned nevio18324 Aug 19, 2025
@nevio18324 nevio18324 removed their request for review August 19, 2025 08:30
lcanobbio and others added 15 commits August 19, 2025 11:33
@lcanobbio
fix: Correctly chose color in target score value #1570
c551263
@lcanobbio
fix(api): Add commit- and targetGoal to Overview and KeyResult #1570
3ff91bd
@lcanobbio
feat: Add Calculation commitGoal and targetGoal #1570
d3cc49b
@lcanobbio
style: Rename commitGoal and targetGoal
b452f18
@lcanobbio
fix: Rename commit- targetGoal in frontend and revise calculation logic
f596351 
#1570
@lcanobbio
test: Remove unit from builder #1570
8eb1b0e
@lcanobbio
test: Update integration and unit tests and a bit of formatting
992d769
@nevio18324 @lcanobbio
test: fix frontend unit tests #1570
66428b9
@nevio18324 @lcanobbio
test: calculate correct commitvalues and targetvalues for test data #…
f292117 
…1570
@nevio18324 @lcanobbio
test: Fix some of the e2e tests #1570
9ef9246
@nevio18324 @lcanobbio
test: Update testdata #1570
75ca89a
@lcanobbio
refactor: Rename wordingCommitValue and wordingTargetValue #1570
62a29fd
@ManuelMoeri @lcanobbio
fix(frontend): Fix updating of commitValue when creating new key-resu…
bfaff1b 
…lts #1570
@ManuelMoeri @lcanobbio
style(backend): Format backend #1570
bd7841e
@ManuelMoeri @lcanobbio
test(frontend): Extend failing test to match new changes #1570
459932f
@lcanobbio lcanobbio force-pushed the bug/1570-visual-has-the-wrong-color branch from 7ee0548 to a26033f Compare August 19, 2025 09:33
@lcanobbio lcanobbio marked this pull request as ready for review August 19, 2025 09:40
MasterEvarior
MasterEvarior approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took way longer to finish this than anticipated but finally finished. I got no notes, this is ready to merge. Great job! 💯 🚀

@MasterEvarior MasterEvarior merged commit 377ee46 into main Aug 19, 2025
20 checks passed
@MasterEvarior MasterEvarior deleted the bug/1570-visual-has-the-wrong-color branch August 19, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterEvarior MasterEvarior MasterEvarior approved these changes

Assignees

@MasterEvarior MasterEvarior

@lcanobbio lcanobbio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Visual has the wrong color

6 participants

@lcanobbio @nevio18324 @peggimann @MasterEvarior @ManuelMoeri