Skip to content

feat: add help button #541#711

Open
fstreit1 wants to merge 70 commits into
mainfrom
feature/541-add-help-button
Open

feat: add help button #541#711
fstreit1 wants to merge 70 commits into
mainfrom
feature/541-add-help-button

Conversation

@fstreit1

@fstreit1 fstreit1 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

fstreit1 added 24 commits July 7, 2026 08:32
@fstreit1
feat(backend): add a new property containing the url the help button …
0aeb3d8 
…should lead to #541
@fstreit1
feat(backend): write a configuration method for getting the support p…
b737551 
…age url from the properties file #541
@fstreit1
feat(backend): add a new dto for transfering the support page url #541
5d5eba7
@fstreit1
feat(backend): write a mapper for translating the url string to a dto #…
4cacdd2 
…541
@fstreit1
feat(backend): change the old enpoint url and add a new endpoint for …
3f9ca7f 
…fetching the url #541
@fstreit1
feat(backend): change the security config so the new endpoint for get…
608453b 
…ting the url is reachable #541
@fstreit1
feat(frontend): add a new help attribute to the de.json #541
a72c94b
@fstreit1
feat(frontend): change the test so the url points to the old endpoint…
bc211cc 
… again #541
@fstreit1
feat(frontend): add a fetch for the new endpoint which provides the s…
bac56f4 
…upport page url #541
@fstreit1
feat(frontend): implement a new model for containing the support page…
7f47000 
… url #541
@fstreit1
fix(frontend): rewrite import so modelname fits PascalCase convention #…
29d43f2 
…541
@fstreit1
feat(frontend): add a new signal for containing the href to the suppo…
b06cd45 
…rt page #541
@fstreit1
feat(frontend): add the button in the top bar #541
b98df21
@fstreit1
refactor(backend): remove unnecessary default value #541
3b7c04c
@fstreit1
feat(backend): add check if configured url is valid #541
0e05cf3
@fstreit1
fix(backend): rewrite check for valid url so the url can not contain …
07bf144 
…spaces #541
@fstreit1
test(backend): write tests for the check if a url is valid #541
b2a8d16
@fstreit1
feat(backend): add check if the url is valid #541
a5f2b56
@fstreit1
fix(backend): fix test so it uses the changed endpoint url #541
ac2add8
@fstreit1
test(backend): write test if the endpoint deliveres the correct url #541
a281790
@fstreit1
test: write test data in properties file and in test-data #541
f1d8b55
@fstreit1
test(frontend): write a test if the fetch for the support page endpoi…
de804ca 
…nt returns the correct data #541
@fstreit1
fix(backend): fix the test which checks if the endpoint for providing…
4dc3947 
… the support page url works #541
@fstreit1
test(frontend): write frontend test #541
62e97b9
@fstreit1 fstreit1 requested a review from MasterEvarior as a code owner July 8, 2026 06:48
@fstreit1 fstreit1 linked an issue Jul 8, 2026 that may be closed by this pull request
Technical Story: Add Help Button #541
Open
4 tasks
@fstreit1 fstreit1 self-assigned this Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Backend Test Results

756 tests  +3   756 ✅ +3   58s ⏱️ +2s
 65 suites +1     0 💤 ±0 
 65 files   +1     0 ❌ ±0 

Results for commit bcc040e. ± Comparison against base commit 365cfe7.

♻️ This comment has been updated with latest results.

@fstreit1 fstreit1 assigned fstreit1 and unassigned fstreit1 Jul 13, 2026
@fstreit1 fstreit1 marked this pull request as ready for review July 13, 2026 09:24
kcinay055679
kcinay055679 requested changes Jul 13, 2026
View reviewed changes
Comment thread backend/src/main/java/ch/puzzle/pcts/configuration/AppConfiguration.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/configuration/AppConfiguration.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/appconfiguration/AppConfigurationDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/ConfigurationController.java Outdated
Comment thread backend/src/test/java/ch/puzzle/pcts/configuration/AppConfigurationTest.java Outdated
Comment thread backend/src/test/resources/application-test.properties Outdated
@kcinay055679

kcinay055679 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

and one e2e test fails, pls look at that too

MasterEvarior
MasterEvarior requested changes Jul 13, 2026
View reviewed changes
Comment thread backend/src/main/java/ch/puzzle/pcts/configuration/AppConfiguration.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/configuration/AppConfiguration.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/configuration/AppConfiguration.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/configuration/AppConfiguration.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/ConfigurationController.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/appconfiguration/AppConfigurationDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/appconfiguration/AppConfigurationDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/mapper/AppConfigurationMapper.java
Comment thread backend/src/main/resources/application-dev.properties Outdated
Comment thread frontend/src/app/app.component.html Outdated
@fstreit1 fstreit1 marked this pull request as draft July 13, 2026 12:57
@fstreit1 fstreit1 marked this pull request as ready for review July 14, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmoeri mmoeri mmoeri left review comments
@kcinay055679 kcinay055679 Awaiting requested review from kcinay055679
@MasterEvarior MasterEvarior Awaiting requested review from MasterEvarior MasterEvarior is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@fstreit1 fstreit1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Technical Story: Add Help Button

4 participants

@fstreit1 @kcinay055679 @MasterEvarior @mmoeri