Allow MinioMediaStorage and MinioStaticStorage options to be specified #144
Conversation
| backup_format = get_setting("MINIO_STORAGE_MEDIA_BACKUP_FORMAT", False) | ||
| backup_bucket = get_setting("MINIO_STORAGE_MEDIA_BACKUP_BUCKET", False) |
There was a problem hiding this comment.
Note, the previous default value of False violates the allowed type of T.Optional[str] for MinioStorage.backup_format and MinioStorage.backup_bucket. The updated default is now None, which has the same behavior but the correct type.
This allows `MinioMediaStorage` or `MinioStaticStorage` to be given additional options via `"OPTIONS"` in Django's `STORAGES` setting (available in Django 4.2+). This is backwards-compatible, as all the added parameters are optional. This has the benefit of allowing multiple instances of `MinioMediaStorage` or `MinioStaticStorage` to be created with slightly different options, which previously was impossible (without creating a base `MinioStorage` and re-parsing all settings).
brianhelba
force-pushed
the
storage-options
branch
from
1449d4c to
02de22e
Compare
|
The tests are failing due to Pyright errors. Many of these are already broken on Some new Pyright errors are coming from the fact that this PR implicitly narrows the type of parameters. I'm open to suggestions on how to fix this (without making the code even more awkward), but I don't want to put in too much additional effort until it seems like this PR is likely to be merged. |
|
Ping @thomasf , please let me know if you'll be able to review this, or if there's anyone else with the ability to merge and release on this project. |
| auto_create_policy = get_setting( | ||
| def __init__( # noqa: C901 | ||
| self, | ||
| *, |
There was a problem hiding this comment.
reordering arguments and requiring keyword arguments is an backwards incompatible change and maybe should be mentioned in the (badly maintained) changelog.
I think it should be fine. At least it breaks early if someone is using it with positional arguments now.
This allows
MinioMediaStorageorMinioStaticStorageto be given additional options via"OPTIONS"in Django'sSTORAGESsetting (available in Django 4.2+). This is backwards-compatible, as all the added parameters are optional.This has the benefit of allowing multiple instances of
MinioMediaStorageorMinioStaticStorageto be created with slightly different options, which previously was impossible (without creating a baseMinioStorageand re-parsing all settings).