Make click optional for library installs#39
Open
lewbei wants to merge 1 commit into
Open
Conversation
niccokunzmann
approved these changes
Jun 4, 2026
Member
|
Thanks for the PR! There are merge conflicts now. Could you solve them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
This follows the maintainer checklist from the issue:
clickfrom the base runtime requirementscliextra viaextras_require4.0.0pip install x-wr-timezone[cli]for command line usageImplementation details:
x_wr_timezoneno longer requiresclickclickis installed,x_wr_timezone.mainremains a Click command object, preserving the existing CLI tests and entry point behaviorclickis missing, the CLI entry point exits with a clear install hintVerification:
Result:
162 passed, 188 skipped, 2 warnings.Additional checks:
No-CLI install smoke:
Observed
click None,has_to_standard True, and the CLI prints thepip install x-wr-timezone[cli]hint whenclickis not installed.