Conversation
There was a problem hiding this comment.
🚩 Existing tests and profile code still reference removed o1-mini model
Multiple test files (tests/models/test_openai.py:858-882, tests/profiles/test_openai.py:34, tests/models/test_model.py:278) and profile code (pydantic_ai_slim/pydantic_ai/profiles/openai.py:167-169) still reference o1-mini. This is not a bug because KnownModelName is a type-level hint for autocomplete/IDE support — users can still pass arbitrary model name strings to OpenAIChatModel. The profile special-casing for o1-mini's system prompt role remains useful for anyone passing the string directly. However, the test at tests/profiles/test_openai.py:34 and tests/models/test_model.py:278 might warrant review to determine if they should be updated or removed for consistency with the deprecation intent.
Was this helpful? React with 👍 or 👎 to provide feedback.
| 'gateway/openai:gpt-5', | ||
| 'gateway/openai:o1-2024-12-17', | ||
| 'gateway/openai:o1-mini-2024-09-12', | ||
| 'gateway/openai:o1-mini', |
There was a problem hiding this comment.
🟡 Inconsistent removal: gateway/openai:o1-mini kept while openai:o1-mini removed
openai:o1-mini was removed as a deprecated model, but its gateway/openai:o1-mini counterpart at line 338 was not. Every other model removed in this PR was consistently removed from both the openai: and gateway/openai: sections (e.g., o1-preview, o1-mini-2024-09-12, o1-preview-2024-09-12, chatgpt-4o-latest, etc.), making this an incomplete transformation.
| 'gateway/openai:o1-mini', |
Was this helpful? React with 👍 or 👎 to provide feedback.
Docs Preview
|
Deprecated list
chatgpt-4o-latesthttps://developers.openai.com/api/docs/deprecations#2025-11-18-chatgpt-4o-latest-snapshotcodex-mini-latesthttps://developers.openai.com/api/docs/deprecations#2025-11-17-codex-mini-latest-model-snapshotgpt-4-0125-preview,gpt-4-turbo-preview,gpt-4-1106-previewhttps://developers.openai.com/api/docs/deprecations#2025-09-26-legacy-gpt-model-snapshotsgpt-4-32k,gpt-4-32k-0613https://developers.openai.com/api/docs/deprecations#2024-06-06-gpt-4-32k-and-vision-preview-modelso1-mini,o1-mini-2024-09-12,o1-preview,o1-preview-2024-09-12https://developers.openai.com/api/docs/deprecations#2025-04-28-o1-preview-and-o1-minigpt-4o-audio-preview-2024-10-01https://developers.openai.com/api/docs/deprecations#2025-06-10-gpt-4o-audio-preview-2024-10-01Doesn't exist
gpt-5.1-miniPre-Review Checklist
make formatandmake typecheck.Pre-Merge Checklist