Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions pydantic_ai_slim/pydantic_ai/models/__init__.py
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Existing tests and profile code still reference removed o1-mini model

Multiple test files (tests/models/test_openai.py:858-882, tests/profiles/test_openai.py:34, tests/models/test_model.py:278) and profile code (pydantic_ai_slim/pydantic_ai/profiles/openai.py:167-169) still reference o1-mini. This is not a bug because KnownModelName is a type-level hint for autocomplete/IDE support — users can still pass arbitrary model name strings to OpenAIChatModel. The profile special-casing for o1-mini's system prompt role remains useful for anyone passing the string directly. However, the test at tests/profiles/test_openai.py:34 and tests/models/test_model.py:278 might warrant review to determine if they should be updated or removed for consistency with the deprecation intent.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,6 @@
'gateway/groq:playai-tts',
'gateway/groq:playai-tts-arabic',
'gateway/groq:qwen/qwen-3-32b',
'gateway/openai:chatgpt-4o-latest',
'gateway/openai:codex-mini-latest',
'gateway/openai:computer-use-preview-2025-03-11',
'gateway/openai:computer-use-preview',
'gateway/openai:gpt-3.5-turbo-0125',
Expand All @@ -283,15 +281,9 @@
'gateway/openai:gpt-3.5-turbo-16k-0613',
'gateway/openai:gpt-3.5-turbo-16k',
'gateway/openai:gpt-3.5-turbo',
'gateway/openai:gpt-4-0125-preview',
'gateway/openai:gpt-4-0314',
'gateway/openai:gpt-4-0613',
'gateway/openai:gpt-4-1106-preview',
'gateway/openai:gpt-4-32k-0314',
'gateway/openai:gpt-4-32k-0613',
'gateway/openai:gpt-4-32k',
'gateway/openai:gpt-4-turbo-2024-04-09',
'gateway/openai:gpt-4-turbo-preview',
'gateway/openai:gpt-4-turbo',
'gateway/openai:gpt-4-vision-preview',
'gateway/openai:gpt-4.1-2025-04-14',
Expand All @@ -304,7 +296,6 @@
'gateway/openai:gpt-4o-2024-05-13',
'gateway/openai:gpt-4o-2024-08-06',
'gateway/openai:gpt-4o-2024-11-20',
'gateway/openai:gpt-4o-audio-preview-2024-10-01',
'gateway/openai:gpt-4o-audio-preview-2024-12-17',
'gateway/openai:gpt-4o-audio-preview-2025-06-03',
'gateway/openai:gpt-4o-audio-preview',
Expand All @@ -330,7 +321,6 @@
'gateway/openai:gpt-5.1-chat-latest',
'gateway/openai:gpt-5.1-codex-max',
'gateway/openai:gpt-5.1-codex',
'gateway/openai:gpt-5.1-mini',
'gateway/openai:gpt-5.1',
'gateway/openai:gpt-5.2-2025-12-11',
'gateway/openai:gpt-5.2-chat-latest',
Expand All @@ -345,10 +335,7 @@
'gateway/openai:gpt-5.4',
'gateway/openai:gpt-5',
'gateway/openai:o1-2024-12-17',
'gateway/openai:o1-mini-2024-09-12',
'gateway/openai:o1-mini',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Inconsistent removal: gateway/openai:o1-mini kept while openai:o1-mini removed

openai:o1-mini was removed as a deprecated model, but its gateway/openai:o1-mini counterpart at line 338 was not. Every other model removed in this PR was consistently removed from both the openai: and gateway/openai: sections (e.g., o1-preview, o1-mini-2024-09-12, o1-preview-2024-09-12, chatgpt-4o-latest, etc.), making this an incomplete transformation.

Suggested change
'gateway/openai:o1-mini',
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

'gateway/openai:o1-preview-2024-09-12',
'gateway/openai:o1-preview',
'gateway/openai:o1-pro-2025-03-19',
'gateway/openai:o1-pro',
'gateway/openai:o1',
Expand Down Expand Up @@ -486,8 +473,6 @@
'moonshotai:moonshot-v1-32k',
'moonshotai:moonshot-v1-8k-vision-preview',
'moonshotai:moonshot-v1-8k',
'openai:chatgpt-4o-latest',
'openai:codex-mini-latest',
'openai:computer-use-preview-2025-03-11',
'openai:computer-use-preview',
'openai:gpt-3.5-turbo-0125',
Expand All @@ -497,15 +482,9 @@
'openai:gpt-3.5-turbo-16k-0613',
'openai:gpt-3.5-turbo-16k',
'openai:gpt-3.5-turbo',
'openai:gpt-4-0125-preview',
'openai:gpt-4-0314',
'openai:gpt-4-0613',
'openai:gpt-4-1106-preview',
'openai:gpt-4-32k-0314',
'openai:gpt-4-32k-0613',
'openai:gpt-4-32k',
'openai:gpt-4-turbo-2024-04-09',
'openai:gpt-4-turbo-preview',
'openai:gpt-4-turbo',
'openai:gpt-4-vision-preview',
'openai:gpt-4.1-2025-04-14',
Expand All @@ -518,7 +497,6 @@
'openai:gpt-4o-2024-05-13',
'openai:gpt-4o-2024-08-06',
'openai:gpt-4o-2024-11-20',
'openai:gpt-4o-audio-preview-2024-10-01',
'openai:gpt-4o-audio-preview-2024-12-17',
'openai:gpt-4o-audio-preview-2025-06-03',
'openai:gpt-4o-audio-preview',
Expand All @@ -544,7 +522,6 @@
'openai:gpt-5.1-chat-latest',
'openai:gpt-5.1-codex-max',
'openai:gpt-5.1-codex',
'openai:gpt-5.1-mini',
'openai:gpt-5.1',
'openai:gpt-5.2-2025-12-11',
'openai:gpt-5.2-chat-latest',
Expand All @@ -559,10 +536,6 @@
'openai:gpt-5.4',
'openai:gpt-5',
'openai:o1-2024-12-17',
'openai:o1-mini-2024-09-12',
'openai:o1-mini',
'openai:o1-preview-2024-09-12',
'openai:o1-preview',
'openai:o1-pro-2025-03-19',
'openai:o1-pro',
'openai:o1',
Expand Down
Loading