Skip to content

Add pre-commit#1075

Merged
scaramallion merged 4 commits into
pydicom:mainfrom
DimitriPapadopoulos:pre-commit
Mar 7, 2026
Merged

Add pre-commit#1075
scaramallion merged 4 commits into
pydicom:mainfrom
DimitriPapadopoulos:pre-commit

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

Reference issue

#1068

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft March 7, 2026 07:07
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 7, 2026 07:08
@DimitriPapadopoulos DimitriPapadopoulos changed the title Pre commit Add pre-commit Mar 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (d3d68f5) to head (c702239).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1075   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          28       28           
  Lines        8984     8984           
=======================================
  Hits         8973     8973           
  Misses         11       11           
Files with missing lines Coverage Δ
pynetdicom/dimse_messages.py 100.00% <100.00%> (ø)
pynetdicom/transport.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scaramallion scaramallion merged commit a9b9312 into pydicom:main Mar 7, 2026
20 of 21 checks passed
@scaramallion
Copy link
Copy Markdown
Member

Thanks!

@DimitriPapadopoulos DimitriPapadopoulos deleted the pre-commit branch March 7, 2026 21:51
@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

Something's wrong:

$ pre-commit run -a
[...]
ruff check...........................................(no files to check)Skipped
black....................................................................Passed
mypy.................................................(no files to check)Skipped
$ 

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

By the way, have you actually enabled pre-commit.ci in this repository?

@scaramallion
Copy link
Copy Markdown
Member

Whoops, sorry. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants