Address no files to check pre-commit message

[DimitriPapadopoulos]

Reference issue

#1075 (comment)

It appears MyPy hasn't been run for ages:

Found 4081 errors in 80 files (checked 113 source files)

I think it doesn't make sense to try to enable it in CI until there errors are addressed.

Tasks

• Unit tests added that reproduce issue or prove feature is working
• Fix or feature added
• Documentation and examples updated (if relevant)
• Unit tests passing and coverage at 100% after adding fix/feature
• Type annotations updated and passing with mypy
• Apps updated and tested (if relevant)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (a9b9312) to head (c17fbf1).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1077   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          28       28           
  Lines        8984     8986    +2     
=======================================
+ Hits         8973     8975    +2     
  Misses         11       11           

Files with missing lines	Coverage Δ
pynetdicom/_handlers.py	100.00% <100.00%> (ø)
pynetdicom/ae.py	100.00% <100.00%> (ø)
pynetdicom/association.py	100.00% <100.00%> (ø)
pynetdicom/dimse_messages.py	100.00% <ø> (ø)
pynetdicom/dsutils.py	100.00% <100.00%> (ø)
pynetdicom/events.py	100.00% <100.00%> (ø)
pynetdicom/pdu_items.py	100.00% <100.00%> (ø)
pynetdicom/presentation.py	100.00% <100.00%> (ø)
pynetdicom/service_class.py	100.00% <100.00%> (ø)
pynetdicom/utils.py	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scaramallion]

Found 4081 errors in 80 files (checked 113 source files)

It shouldn't be that bad, I at least ran it locally when doing the v3 release.

80 files? Is it checking the tests directory as well?

[DimitriPapadopoulos]

I haven't changed what it checks, only test_files are excluded.

Actually, this is a known pre-commit feature: in order to parallelize checks, it runs hooks on each file individually and explicitly. Unfortunately, explicitly passing files to the underlying software may override its exclude option. That's one reason why ruff has force-exclude option:

This is useful for pre-commit, which explicitly passes all changed files to the ruff-pre-commit plugin, regardless of whether they're marked as excluded by Ruff's own settings.

Neither codespell nor MyPy have such an option. Therefore, files have to be excluded twice, once in the MyPy settings in case it is run standalone, and once in pre-commit settings. That's rather unfortunate, but there's no way around that.

[DimitriPapadopoulos]

Much better after getting pre-commit to exclude tests and the like:

Found 41 errors in 10 files (checked 28 source files)