Open
Conversation
Member
|
I've added the notebook to the index so that it get's included when building the html. The notebook now appears in the readthedocs preview. |
mberz
requested changes
Mar 17, 2026
Member
mberz
left a comment
mberz
left a comment
There was a problem hiding this comment.
Thanks for the notebook. I've added a couple of comments.
Some general comments:
- You use inline comments a lot, I think these could be replaced by markdown above the code cell.
- Some parts feel a bit out of place like the RIR based on the analytic model and the Schroeder integration. I suggest to remove those.
- Please empty all cells before committing a notebook. You can have a look at the contribution guidelines here https://pyfar-gallery--140.org.readthedocs.build/en/140/contribute/gallery/contribution_gallery.html#get-started. They include info on setting up a pre-commit hook to make sure that only cleared notebooks are committed.
github-project-automation
bot
moved this from Implementation in progress
to Require review
in Weekly Planning
Member
|
CircleCI indicates that there's a broken reference. You can have a look here: |
|
Just a general remark: When presenting the notebook, wouldn't it make more sense to keep the text part rather brief and focus on code? |
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for pyrato introduction notebook
Note
Uses pyfar and pyrato develop branch