RAP Clarity based on energy ratio #109
Merged
f-brinkmann merged 20 commits intodevelopfrom Mar 1, 2026
Merged
Conversation
sbch22
requested review from
ahms5,
artur-pa,
f-brinkmann,
hoyer-a and
mberz
hoyer-a
requested changes
Dec 18, 2025
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
This was referenced Feb 18, 2026
Member
|
Seems like this is not finished, moving to implementation in progress |
sbch22
force-pushed
the
feature/clarity_from_energy_ratio
branch
from
7a49ad9 to
c4086c5
Compare
f-brinkmann
requested changes
Feb 26, 2026
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Thanks for implementing. I only had minor suggestions
Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>
f-brinkmann
approved these changes
Feb 28, 2026
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
artur-pa
approved these changes
Mar 1, 2026
Contributor
artur-pa
left a comment
artur-pa
left a comment
There was a problem hiding this comment.
Thank you for the changes! Looks good to me!
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
Member
|
Hm, artur approved above although it shows not up officially. Merging for this reaseon. |
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
mberz
added a commit
that referenced
this pull request
Mar 3, 2026
### Which issue(s) are closed by this pull request? Closes #80 ### Changes proposed in this pull request: - implements a new function for definition - tests added in the mold of the tests for RAP Clarity (#109 ) --------- Co-authored-by: Artur Paszkiewicz <99469971+artur-pa@users.noreply.github.com> Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: