enable edc calculation of signals with cdim > 1#113
Merged
Conversation
hoyer-a
requested review from
a team,
SimonBuechner,
ahms5,
artur-pa,
f-brinkmann and
mberz
f-brinkmann
reviewed
Jan 6, 2026
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Thanks for taking care. I would suggest to make the tests a little more strict.
Member
|
I've merged #117. Feel free to rebase. |
3 tasks
hoyer-a
force-pushed
the
enhance/allow-multidim-edc
branch
from
5ee9bf5 to
6922d21
Compare
f-brinkmann
approved these changes
Jan 21, 2026
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Thanks for the update. Looks good to me now!
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
mberz
approved these changes
Jan 22, 2026
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #110
Changes proposed in this pull request:
Question
I considered this a bugfix and branched off from main, is this correct?