Skip to content

Fix latest sdl2-compat/sdl3 fails #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankith26 merged 1 commit into from
Feb 7, 2026
Merged

Fix latest sdl2-compat/sdl3 fails #3687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/draw_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7537,7 +7537,9 @@ def test_aafunctions_depth_segfault(self):
if depth == 8:
self.assertEqual(surf.get_at(pixel), pixel_colors_8[i])
elif depth == 16:
self.assertEqual(surf.get_at(pixel), pixel_colors_16[i])
# allow small delta difference to account for SDL3 changes.
for x, y in zip(surf.get_at(pixel), pixel_colors_16[i]):
self.assertAlmostEqual(x, y, delta=2)
else:
self.assertEqual(surf.get_at(pixel), pixel_colors_24_32[i])

Expand Down
5 changes: 4 additions & 1 deletion test/surface_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,10 @@ def test_fill_rle(self):
self.assertEqual(
blit_surf.mustlock(), (blit_surf.get_flags() & pygame.RLEACCEL) != 0
)
self.assertTrue(blit_surf.get_flags() & pygame.RLEACCEL)
if pygame.version.SDL < (2, 32, 50):
# This bit fails on SDL2-compat and SDL3
# https://github.com/libsdl-org/sdl2-compat/issues/575
self.assertTrue(blit_surf.get_flags() & pygame.RLEACCEL)

def test_fill_raise_exceptions(self):
surf = pygame.Surface((5, 5))
Expand Down
Loading