Skip to content

Initial fixes for Python 3.14 #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 15, 2025

Tested against 3.14.0b1 locally. We might still need to adjust some things as more pre-release versions come out but this provides a good starting point in combination with #2731.

Relevant changes for Python 3.14

@cdce8p cdce8p added Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14 labels May 15, 2025
@cdce8p cdce8p requested a review from Pierre-Sassoulas May 15, 2025 22:51
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.23%. Comparing base (3636bc2) to head (d52f79d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
astroid/brain/brain_typing.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (88.88%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
+ Coverage   93.21%   93.23%   +0.02%     
==========================================
  Files          93       93              
  Lines       11072    11078       +6     
==========================================
+ Hits        10321    10329       +8     
+ Misses        751      749       -2     
Flag Coverage Δ
linux 93.10% <88.88%> (+0.02%) ⬆️
pypy 93.23% <88.88%> (+0.02%) ⬆️
windows 93.22% <88.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_pathlib.py 92.00% <100.00%> (ø)
astroid/const.py 100.00% <100.00%> (ø)
astroid/brain/brain_typing.py 87.11% <80.00%> (-0.39%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdce8p cdce8p removed the request for review from Pierre-Sassoulas May 16, 2025 14:52
@cdce8p cdce8p merged commit 43111bb into pylint-dev:main May 16, 2025
21 of 22 checks passed
@cdce8p cdce8p deleted the fix-brain-3.14 branch May 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants