Fix Pyreverse: Aggregations aren't filtered according to filter mode (PUB_ONLY, etc.) #10379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
requested changes
May 14, 2025
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 3bfca11 |
for more information, see https://pre-commit.ci
|
I've added the tests using the example from the issue. Please let me know if there's anything else needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR fixes an issue in Pyreverse where class-level aggregations and associations were not being filtered according to the selected filter mode (PUB_ONLY, ALL, etc.).
Currently, even private or protected attributes result in relationships in the diagram, regardless of the filter setting. This fix ensures that relationships are only created for attributes that match the visibility filter.
Closes #10373