Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
=======================================
Coverage 92.55% 92.55%
=======================================
Files 71 71
Lines 10279 10279
=======================================
Hits 9514 9514
Misses 765 765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@juanitorduz I've uploaded all my design documents here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MMM Data & Plotting Framework Design Documents
These four research documents outline a comprehensive three-component architecture for the MMM data handling and interactive plotting framework. The design addresses the "trapped data" problem where users couldn't access summary statistics used in plots, and provides a modern, interactive visualization layer.
2026-01-07_21-08-47_mmm-data-plotting-framework-architecture.md— The foundational architecture document establishing the three-component decoupled system. Evaluates requirements, identifies current pain points (data duplication, matplotlib lock-in, no time aggregation), and recommends both factory functions and class wrappers as first-class citizens.2026-01-07_22-19-51_codifying-idata-conventions-component1-wrapper.md— Component 1 (Data Wrapper) design. DefinesMMMIDataWrapperthat codifies InferenceData conventions, providing validated access to idata with operations for date/dimension filtering, time aggregation, and scaling transformations. Catalogs 50+ naming patterns and implicit conventions.2026-01-08_20-09-03_component2-mmm-summary-object-implementation.md— Component 2 (Summary Object) design. SpecifiesMMMSummaryFactorythat transforms wrapped data into structured DataFrames with HDI statistics. Supports both Pandas and Polars output viaoutput_formatparameter, with Pandas as default for PyMC/ArviZ ecosystem alignment.2026-01-09_17-16-52_component3-plotting-suite-implementation.md— Component 3 (Plotting Suite) design. Details the new Plotly-based interactive plotting functions using Narwhals for DataFrame-agnostic input and Plotly Express faceting for multi-dimensional MMM models (country, brand, region). Coexists alongside the existing matplotlib-based MMMPlotSuite.