Skip to content

refactor(mmm): rename optimize_budget **minimize_kwargs to **allocate_budget_kwargs #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anevolbap wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(mmm): rename optimize_budget **minimize_kwargs to **allocate_budget_kwargs #2563

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
734acea
refactor(mmm): rename optimize_budget **minimize_kwargs to **allocate…
anevolbap May 12, 2026
7cfeebb
Merge branch 'main' into fix/1660-allocate-budget-kwargs
anevolbap May 13, 2026
9a4c529
Merge branch 'main' into fix/1660-allocate-budget-kwargs
juanitorduz May 13, 2026
1d3712c
Merge branch 'main' into fix/1660-allocate-budget-kwargs
anevolbap May 14, 2026
59098d2
Merge branch 'main' into fix/1660-allocate-budget-kwargs
juanitorduz May 15, 2026
0bf5300
Merge branch 'main' into fix/1660-allocate-budget-kwargs
anevolbap May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pymc_marketing/mmm/mmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3713,7 +3713,7 @@ def optimize_budget(
budget_distribution_over_period: xr.DataArray | None = None,
cost_per_unit: pd.DataFrame | xr.DataArray | None = None,
callback: bool = False,
**minimize_kwargs,
**allocate_budget_kwargs,
) -> (
tuple[xr.DataArray, OptimizeResult]
| tuple[xr.DataArray, OptimizeResult, list[dict[str, Any]]]
Expand Down Expand Up @@ -3764,8 +3764,8 @@ def optimize_budget(
**This is independent of the historical cost_per_unit.**
callback : bool
Whether to return callback information tracking optimization progress.
**minimize_kwargs
Additional arguments for the optimizer.
**allocate_budget_kwargs
Additional arguments for :meth:`~pymc_marketing.mmm.budget_optimizer.BudgetOptimizer.allocate_budget`.

Returns
-------
Expand Down Expand Up @@ -3814,7 +3814,7 @@ def optimize_budget(
total_budget=budget,
budget_bounds=budget_bounds,
callback=callback,
**minimize_kwargs,
**allocate_budget_kwargs,
)

def _apply_budget_distribution_pattern(
Expand Down