Skip to content

Remove deprecated serialization shims kept for Legacy MMM#2599

Open
juanitorduz wants to merge 2 commits into
mainfrom
issue-2430
Open

Remove deprecated serialization shims kept for Legacy MMM#2599
juanitorduz wants to merge 2 commits into
mainfrom
issue-2430

Conversation

@juanitorduz
Copy link
Copy Markdown
Collaborator

@juanitorduz juanitorduz commented May 19, 2026

Closes #2430


📚 Documentation preview 📚: https://pymc-marketing--2599.org.readthedocs.build/en/2599/

@cursor
Copy link
Copy Markdown
Contributor

cursor Bot commented May 19, 2026

PR Summary

Medium Risk
Removes deprecated lookup_name-based deserialization paths and public exports, which can break loading of older serialized MMM artifacts that lack __type__ unless they go through the explicit migration tooling.

Overview
Drops the Legacy-MMM serialization shims for adstock and saturation: adstock_from_dict/saturation_from_dict and the associated lookup tables are removed, and these symbols are no longer exported from pymc_marketing.mmm.

MediaTransformation.from_dict is simplified to always use serialization.deserialize() for nested adstock/saturation, and tests are updated to enumerate transformation subclasses directly and to assert that lookup_name-only payloads now fail with a SerializationError (plus regression checks that the removed shims are not importable).

Reviewed by Cursor Bugbot for commit 2db827c. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.93%. Comparing base (48f5ece) to head (2db827c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
+ Coverage   93.91%   93.93%   +0.02%     
==========================================
  Files          93       93              
  Lines       14226    14185      -41     
==========================================
- Hits        13360    13325      -35     
+ Misses        866      860       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanitorduz juanitorduz self-assigned this May 19, 2026
@juanitorduz juanitorduz added this to the 1.0 milestone May 19, 2026
@juanitorduz
Copy link
Copy Markdown
Collaborator Author

@BugBot review

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit dd80acf. Configure here.

Comment thread tests/mmm/components/test_adstock.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated serialization shims kept for Legacy MMM (adstock_from_dict, saturation_from_dict)

2 participants