chore: remove dead catch_warnings blocks from add_groups migration#2652
Open
williambdean wants to merge 2 commits into
Open
chore: remove dead catch_warnings blocks from add_groups migration#2652williambdean wants to merge 2 commits into
williambdean wants to merge 2 commits into
Conversation
- The 'fit_data not defined in InferenceData scheme' warning was emitted by arviz add_groups, which has been replaced by idata["/fit_data"] = fit_data. DataTree assignment never raises it. - Removed dead with/catch_warnings/filterwarnings blocks in mixed_logit, mnl_logit, nested_logit, maxdiff.
- Same 'fit_data not defined in InferenceData scheme' warning blocks no longer needed in conftest fixtures after add_groups migration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.0.0 #2652 +/- ##
==========================================
- Coverage 94.07% 94.07% -0.01%
==========================================
Files 97 97
Lines 14617 14606 -11
==========================================
- Hits 13751 13740 -11
Misses 866 866 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Please take a look @daimon-pymclabs |
Contributor
|
Took a look — this is good to merge. Checked the mechanical side carefully:
One optional belt-and-suspenders: a quick run of the customer_choice fit tests under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'fit_data not defined in InferenceData scheme' warning was emitted by arviz's
add_groups, which was replaced byidata["/fit_data"] = fit_datain the PyMC 6 migration (#2616). DataTree assignment never raises this warning, making thecatch_warnings/filterwarningsblocks dead code.Removed in:
mixed_logit.py,mnl_logit.py,nested_logit.py,maxdiff.py.Flagged by @daimon-pymclabs in #2616 review.
📚 Documentation preview 📚: https://pymc-marketing--2652.org.readthedocs.build/en/2652/