Conversation
AA-Turner
approved these changes
Feb 20, 2025
Member
|
Thanks, this looks good to me. (Just in case this is a starting point, I'll say now that I don't generally favour large-scale code cleanups or strict enforcement of style rules. :-) |
Member
Author
That wasn't my plan. I just did this PR as my editor is configured to auto-remove additional whitespaces on save, so while working on all the other PRs I constantly had to make sure to not include unrelated changes. Figured it might be easier to just clean them up in one go. |
Member
|
Thanks, that makes total sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed these while working on other parts of the codebase. Use pre-commit checks to auto-fix it for the whole codebase
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#trailing-whitespace
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#end-of-file-fixer
Added a basic
.pre-commit-config.yamlfile to make running them easier. I've stop short of enforcing it to not add an additional required development dependency.