Skip to content

Formatting improvements#726

Merged
takluyver merged 3 commits intopypa:mainfrom
cdce8p:misc
Mar 1, 2025
Merged

Formatting improvements#726
takluyver merged 3 commits intopypa:mainfrom
cdce8p:misc

Conversation

@cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 20, 2025

Noticed these while working on other parts of the codebase. Use pre-commit checks to auto-fix it for the whole codebase

Added a basic .pre-commit-config.yaml file to make running them easier. I've stop short of enforcing it to not add an additional required development dependency.

@takluyver
Copy link
Member

Thanks, this looks good to me.

(Just in case this is a starting point, I'll say now that I don't generally favour large-scale code cleanups or strict enforcement of style rules. :-)

@takluyver takluyver added this to the 3.12 milestone Mar 1, 2025
@takluyver takluyver merged commit ad93dbb into pypa:main Mar 1, 2025
16 checks passed
@cdce8p cdce8p deleted the misc branch March 1, 2025 12:59
@cdce8p
Copy link
Member Author

cdce8p commented Mar 1, 2025

(Just in case this is a starting point, I'll say now that I don't generally favour large-scale code cleanups or strict enforcement of style rules. :-)

That wasn't my plan. I just did this PR as my editor is configured to auto-remove additional whitespaces on save, so while working on all the other PRs I constantly had to make sure to not include unrelated changes. Figured it might be easier to just clean them up in one go.

@takluyver
Copy link
Member

Thanks, that makes total sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants