Fix setting fullname for ORCID #666
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, fullname was set to `response['person']['name']`, which in ORCID is a large json object. Everywhere else, fullname is assumed to be a string. It cannot be used directly as a fullname but needs converting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 77.78% 77.78%
=======================================
Files 352 352
Lines 10865 10866 +1
Branches 489 489
=======================================
+ Hits 8451 8452 +1
Misses 2234 2234
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nijel
reviewed
Feb 15, 2022
| first_name = name.get('given-names', {}).get('value', '') | ||
| last_name = name.get('family-name', {}).get('value', '') | ||
| fullname = first_name + ' ' + last_name | ||
| fullname = fullname.strip() |
Member
There was a problem hiding this comment.
Can you please look why this is not covered by tests? The user data payload seems to be present in the test case, but it doesn't seem to be used.
nijel
reviewed
May 26, 2025
Member
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, fullname was set to
response['person']['name'], which inORCID is a large json object. Everywhere else, fullname is assumed to be
a string. It cannot be used directly as a fullname but needs converting.
Proposed changes
The patch ensures that fullname is a string, in a similar way to how other backends do it.
Types of changes
Please check the type of change your PR introduces:
Checklist
(I had to install libxmlsec1-dev manually on debian in order to get tox to run.)