Skip to content

Fix setting fullname for ORCID #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijel merged 4 commits into from
May 26, 2025
Merged

Fix setting fullname for ORCID #666

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2846d5a
Fix setting fullname for ORCID
hmpf Feb 15, 2022
0744ba8
Merge branch 'master' into bug/orcid-fullname
nijel May 26, 2025
3320e69
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 26, 2025
79938ea
Update social_core/backends/orcid.py
nijel May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions social_core/backends/orcid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ def get_user_details(self, response):
if person:
name = person.get('name')

fullname = name

if name:
first_name = name.get('given-names', {}).get('value', '')
last_name = name.get('family-name', {}).get('value', '')
fullname = first_name + ' ' + last_name
fullname = fullname.strip()
Copy link
Member

@nijel nijel Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please look why this is not covered by tests? The user data payload seems to be present in the test case, but it doesn't seem to be used.


emails = person.get('emails')
if emails:
Expand Down