-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-122631 Add video/3gpp and video/3gpp2 to mimetypes #122632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-122631 Add video/3gpp and video/3gpp2 to mimetypes #122632
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Library/2024-08-02-20-02-38.gh-issue-122631.p4QdB2.rst
Outdated
Show resolved
Hide resolved
…4QdB2.rst Co-authored-by: Peter Bierma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you note, the audio/
versions already exist:
Lines 527 to 530 in efcd65c
'.3gp' : 'audio/3gpp', | |
'.3gpp' : 'audio/3gpp', | |
'.3g2' : 'audio/3gpp2', | |
'.3gpp2' : 'audio/3gpp2', |
The suffixes are the same, though, so this would overwrite as they appear later in the dict. Can you think of a way to fix that?
A
Misc/NEWS.d/next/Library/2024-08-02-20-02-38.gh-issue-122631.p4QdB2.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Adam Turner <[email protected]>
@AA-Turner I have made the requested changes; please review again. I think ideally (Also I'm not sure what's going on with my NEWS build errors, would appreciate any pointers there.) EDIT: I put up a PR on my fork of how I would do the breaking version. I do think it's cleaner, and more future-proof, but obviously it's a breaking change on |
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
These are officially recognized by IANA