Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128978: Fix a NameError in sysconfig.expand_makefile_vars #128979

Merged
merged 4 commits into from
Jan 20, 2025
Merged

gh-128978: Fix a NameError in sysconfig.expand_makefile_vars #128979

merged 4 commits into from
Jan 20, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jan 18, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested a review from FFY00 as a code owner January 18, 2025 10:05
@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2025
Closed
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.12 bug and security fixes and removed awaiting core review labels Jan 18, 2025
@picnixz picnixz requested a review from vstinner January 20, 2025 12:41
vstinner
vstinner reviewed Jan 20, 2025
View reviewed changes
vstinner
vstinner approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz enabled auto-merge (squash) January 20, 2025 13:24
@picnixz picnixz merged commit df66ff1 into python:main Jan 20, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@picnixz @miss-islington
pythongh-128978: Fix a NameError in sysconfig.expand_makefile_vars (
9356f95 
pythonGH-128979)

This fixes a regression introduced by 4a53a39.
(cherry picked from commit df66ff1)

Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@picnixz @miss-islington
pythongh-128978: Fix a NameError in sysconfig.expand_makefile_vars (
837e5d2 
pythonGH-128979)

This fixes a regression introduced by 4a53a39.
(cherry picked from commit df66ff1)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129065 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129066 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 20, 2025
@picnixz picnixz deleted the fix/sysconfig/relic-128978 branch January 20, 2025 13:27
picnixz added a commit that referenced this pull request Jan 20, 2025
@miss-islington @picnixz
[3.13] gh-128978: Fix a NameError in `sysconfig.expand_makefile_var…
55d3d81 
…s` (GH-128979) (#129065)

gh-128978: Fix a `NameError` in `sysconfig.expand_makefile_vars` (GH-128979)

This fixes a regression introduced by 4a53a39.
(cherry picked from commit df66ff1)

Co-authored-by: Bénédikt Tran <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@picnixz @srinivasreddy
pythongh-128978: Fix a NameError in sysconfig.expand_makefile_vars (
598cb08 
python#128979)

This fixes a regression introduced by 4a53a39.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @vstinner