Skip to content

Remove handling for old macOS installer filenames #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove handling for old macOS installer filenames #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 1 addition & 30 deletions add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,8 @@ def run_cmd(
def macos_description(version: tuple[int, int, int]) -> str:
if version >= (3, 14):
return "for macOS 10.15 and later"
elif version >= (3, 12, 6):
return "for macOS 10.13 and later"
else:
return "for macOS 10.9 and later"
return "for macOS 10.13 and later"


def get_file_descriptions(
Expand Down Expand Up @@ -143,33 +141,6 @@ def get_file_descriptions(
("Windows embeddable package (32-bit)", "windows", False, ""),
),
(rx(r"\.exe$"), ("Windows installer (32-bit)", "windows", False, "")),
(
rx(r"-macosx10\.5(_rev\d)?\.(dm|pk)g$"),
(
"macOS 32-bit i386/PPC installer",
"macos",
False,
"for Mac OS X 10.5 and later",
),
),
(
rx(r"-macosx10\.6(_rev\d)?\.(dm|pk)g$"),
(
"macOS 64-bit/32-bit Intel installer",
"macos",
False,
"for Mac OS X 10.6 and later",
),
),
(
rx(r"-macos(x)?10\.9\.(dm|pk)g$"),
(
"macOS 64-bit Intel-only installer",
"macos",
False,
"for macOS 10.9 and later, deprecated",
),
),
(
rx(r"-macos(x)?1[1-9](\.[0-9]*)?\.pkg$"),
(
Expand Down
6 changes: 0 additions & 6 deletions tests/test_add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,6 @@ def test_minor_version_tuple(release: str, expected: tuple[int, int]) -> None:
@pytest.mark.parametrize(
["release", "expected"],
[
((3, 9, 0), "for macOS 10.9 and later"),
((3, 10, 0), "for macOS 10.9 and later"),
((3, 11, 0), "for macOS 10.9 and later"),
((3, 12, 0), "for macOS 10.9 and later"),
((3, 12, 5), "for macOS 10.9 and later"),
((3, 12, 6), "for macOS 10.13 and later"),
((3, 13, 0), "for macOS 10.13 and later"),
((3, 14, 0), "for macOS 10.15 and later"),
],
Expand Down