-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use torch.float8_e8m0fnu
in mx_formats
#1882
base: main
Are you sure you want to change the base?
Conversation
Stack from ghstack (oldest at bottom): |
Summary: Switches our MX code to use the new `torch.float8_e8m0fnu` dtype directly where appropriate. This will allow for easier numerical debugging of scales, as we can easily see the numerical values when they are printed. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: e0d000742ad9a0d1fa5019f6d6391955ef3cc001 ghstack-comment-id: 2721705057 Pull Request resolved: #1882
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1882
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit ba470ae with merge base 9ef2f06 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Switches our MX code to use the new `torch.float8_e8m0fnu` dtype directly where appropriate. This will allow for easier numerical debugging of scales, as we can easily see the numerical values when they are printed. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1c0c2babc58a91c832ad6872668c68268818abe2 ghstack-comment-id: 2721705057 Pull Request resolved: #1882
need to fix CI |
need to reverse #1608 and get a fresh nightly for this to work, will take a look |
Looks like this needs something like the inductor changes from pytorch/pytorch#148461 for tests to pass |
Summary:
Switches our MX code to use the new
torch.float8_e8m0fnu
dtypedirectly where appropriate. This will allow for easier numerical
debugging of scales, as we can easily see the numerical values when they
are printed.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: