Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make printing of MXLinear and MXInferenceLinear more descriptive #1883

Closed
wants to merge 4 commits into from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 13, 2025

Summary:

For now, at least print the config. This is useful during feature development. It's pretty verbose, we can make
the string more concise in a future PR.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 13, 2025

Copy link

pytorch-bot bot commented Mar 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1883

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 93545a4 with merge base 9ef2f06 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
vkuzo added a commit that referenced this pull request Mar 13, 2025
Summary:

For now, at least print the config.  It's pretty verbose, we can make
the string more concise in a future PR.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 37ee8602113ce0ee88cb97538713dd06cc7036c9
ghstack-comment-id: 2722102724
Pull Request resolved: #1883
@vkuzo vkuzo added the topic: for developers Use this tag if this PR is mainly developer facing label Mar 13, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 14, 2025
Summary:

For now, at least print the config.  It's pretty verbose, we can make
the string more concise in a future PR.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c4cc7e9db104592007fad274e613ed053c7679ef
ghstack-comment-id: 2722102724
Pull Request resolved: #1883
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 15, 2025
Summary:

For now, at least print the config.  It's pretty verbose, we can make
the string more concise in a future PR.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b4887b416d23279d0047abf9db666a1ebcf0bbb4
ghstack-comment-id: 2722102724
Pull Request resolved: #1883
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 18, 2025
Summary:

For now, at least print the config.  It's pretty verbose, we can make
the string more concise in a future PR.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 14a19e8c1e29028bc6b72bb55bde5be245511c75
ghstack-comment-id: 2722102724
Pull Request resolved: #1883
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 24, 2025

closing in favor of #1947

@vkuzo vkuzo closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants